| Message ID | bf09b11ec6a0102f85dc2b3289d003271304e24d.1693474728.git.zhoubinbin@loongson.cn (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | soc: loongson: Fix some issues about loongson_pm2 | expand |
Hi Conor: Thanks for your reply. On Thu, Aug 31, 2023 at 11:15 PM Conor Dooley <conor@kernel.org> wrote: > > On Thu, Aug 31, 2023 at 07:43:13PM +0800, Binbin Zhou wrote: > > Now, "loongson,ls2k0500-pmc" is used as fallback compatible, so the > > ls2k1000 compatible in the driver can be dropped directly. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > drivers/soc/loongson/loongson2_pm.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c > > index 796add6e8b63..5ffb77afd9eb 100644 > > --- a/drivers/soc/loongson/loongson2_pm.c > > +++ b/drivers/soc/loongson/loongson2_pm.c > > @@ -197,7 +197,6 @@ static int loongson2_pm_probe(struct platform_device *pdev) > > > > static const struct of_device_id loongson2_pm_match[] = { > > { .compatible = "loongson,ls2k0500-pmc", }, > > - { .compatible = "loongson,ls2k1000-pmc", }, > > What about older devicetrees that do not have the fallback? Aren't you > going to remove support for those? This driver was just merged in during the v6.6 window, and no release will use it until now. commit 67694c076bd7 soc: loongson2_pm: add power management support commit 6054a676e969 soc: dt-bindings: add loongson-2 pm Of course, it was our mistake not to make better use of fallback compatible when submitting the driver, and we hope to fix this mistake soon. Also, this driver will only be used by the LoongArch architecture, no need to worry about other architectures. Thanks. Binbin > > > {}, > > }; > > > > -- > > 2.39.3 > >
On Fri, Sep 01, 2023 at 11:05:12AM +0800, Binbin Zhou wrote: > Hi Conor: > > Thanks for your reply. > > On Thu, Aug 31, 2023 at 11:15 PM Conor Dooley <conor@kernel.org> wrote: > > > > On Thu, Aug 31, 2023 at 07:43:13PM +0800, Binbin Zhou wrote: > > > Now, "loongson,ls2k0500-pmc" is used as fallback compatible, so the > > > ls2k1000 compatible in the driver can be dropped directly. > > > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > > --- > > > drivers/soc/loongson/loongson2_pm.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c > > > index 796add6e8b63..5ffb77afd9eb 100644 > > > --- a/drivers/soc/loongson/loongson2_pm.c > > > +++ b/drivers/soc/loongson/loongson2_pm.c > > > @@ -197,7 +197,6 @@ static int loongson2_pm_probe(struct platform_device *pdev) > > > > > > static const struct of_device_id loongson2_pm_match[] = { > > > { .compatible = "loongson,ls2k0500-pmc", }, > > > - { .compatible = "loongson,ls2k1000-pmc", }, > > > > What about older devicetrees that do not have the fallback? Aren't you > > going to remove support for those? > > This driver was just merged in during the v6.6 window, and no release > will use it until now. Ahh, thanks for the info. Your commits 1-3 should then all have Fixes: tags pointing to the commits tat introduced the problems, if you intend getting these applied as fixes before v6.6 gets released. Thanks, Conor. > commit 67694c076bd7 soc: loongson2_pm: add power management support > commit 6054a676e969 soc: dt-bindings: add loongson-2 pm > > Of course, it was our mistake not to make better use of fallback > compatible when submitting the driver, and we hope to fix this mistake > soon. > Also, this driver will only be used by the LoongArch architecture, no > need to worry about other architectures. > > Thanks. > Binbin > > > > > {}, > > > }; > > > > > > -- > > > 2.39.3 > > >
diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c index 796add6e8b63..5ffb77afd9eb 100644 --- a/drivers/soc/loongson/loongson2_pm.c +++ b/drivers/soc/loongson/loongson2_pm.c @@ -197,7 +197,6 @@ static int loongson2_pm_probe(struct platform_device *pdev) static const struct of_device_id loongson2_pm_match[] = { { .compatible = "loongson,ls2k0500-pmc", }, - { .compatible = "loongson,ls2k1000-pmc", }, {}, };
Now, "loongson,ls2k0500-pmc" is used as fallback compatible, so the ls2k1000 compatible in the driver can be dropped directly. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- drivers/soc/loongson/loongson2_pm.c | 1 - 1 file changed, 1 deletion(-)