From patchwork Sat Jun 17 03:03:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Len Brown X-Patchwork-Id: 9793889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B5EA60325 for ; Sat, 17 Jun 2017 03:03:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CF1027F4B for ; Sat, 17 Jun 2017 03:03:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00115284B9; Sat, 17 Jun 2017 03:03:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0BF9283CB for ; Sat, 17 Jun 2017 03:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbdFQDDa (ORCPT ); Fri, 16 Jun 2017 23:03:30 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:33449 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbdFQDD2 (ORCPT ); Fri, 16 Jun 2017 23:03:28 -0400 Received: by mail-qk0-f196.google.com with SMTP id u8so825847qka.0; Fri, 16 Jun 2017 20:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references:reply-to:organization; bh=vS/65CXVUvBJYzrWCFm3nmFzXQ2j7benFTPYJ0loJZA=; b=iqjC+Rn/FhnZqLERvLllIkL6FHxYOWOZa0UOS4gRD8yfiiOlu2jwJyKkjjxIlr7XCU DQkPSem27Kik+opCgaq3mCfVpBGA20nGkfhjnhauDwscPSVVO0CFd9yWTaSyCeiVTyQa V71RmPEaAJ2Mpbic2ttuNtEAE4W2MrNMi12mQKrMCYwCGIRTBhdcssEO7PN7vc1XL4j3 Ko3prsYVyMXpoGtivtS64qohRGTXUMdP5OiiKlpoP9UcMmjvM+r0KfiBsfPiHCsuLdrz V5R/FdZVCuNeTs+Ck1QTOGfT3R0yBlG0WNZ9aGne95+J0YQAVYmyubJbfw6UfkxTX35f gSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references:reply-to:organization; bh=vS/65CXVUvBJYzrWCFm3nmFzXQ2j7benFTPYJ0loJZA=; b=odw33HNbyuQ3qJ/omG+NSFqKT5+SK0iU3weoFdEJWAYvDfjeY7eVjFnIQcV//In/ow wQoS0sANIuW/VtEPBKIax5y3AY7XyvU9uVovU+cWQXrUsCxXTXFxmOotXZENRB7lH4AH +x1ijAgHRR/AO2euobRgbT6RWW4S81qixV4F+WCEprGZN0mzLfVMxWaeLftC5SoBmP/s 8HZQEQjmkGDP50FM2QDIre83u8LBbPP3dimmeWqMy8HFxUXvefCtgucv1qSIhZB12iX5 b+DSWrOGe/Pa6Sl8JcyW+vcACh2fXXJytIIWoGTs+cZmj1fYZ/Xr2zyBi1hqinYMCnFH z1zA== X-Gm-Message-State: AKS2vOw0mfGgE5lZQ6qLCJ9KYU5o+Q7tkIF4muAdXb9qxyt3C5OxHwi1 3RXRx1KXcjT0Iw== X-Received: by 10.55.178.5 with SMTP id b5mr15728117qkf.2.1497668607376; Fri, 16 Jun 2017 20:03:27 -0700 (PDT) Received: from localhost.localdomain (pool-173-48-65-169.bstnma.fios.verizon.net. [173.48.65.169]) by smtp.gmail.com with ESMTPSA id g34sm2983335qta.46.2017.06.16.20.03.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jun 2017 20:03:26 -0700 (PDT) From: Len Brown To: rafael@kernel.org Cc: x86@kernel.org, srinivas.pandruvada@linux.intel.com, peterz@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Subject: [PATCH 4/4] intel_pstate: skip scheduler hook when in "performance" mode. Date: Fri, 16 Jun 2017 20:03:14 -0700 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497668594-9266-1-git-send-email-lenb@kernel.org> References: <1497668594-9266-1-git-send-email-lenb@kernel.org> In-Reply-To: References: Reply-To: Len Brown Organization: Intel Open Source Technology Center Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Len Brown When the governor is set to "performance", intel_pstate does not need the scheduler hook for doing any calculations. Under these conditions, its only purpose is to continue to maintain cpufreq/scaling_cur_freq. The cpufreq/scaling_cur_freq sysfs attribute is now provided by shared x86 cpufreq code on modern x86 systems, including all systems supported by the intel_pstate driver. So in "performance" governor mode, the scheduler hook can be skipped. This applies to both in Software and Hardware P-state control modes. Suggested-by: Srinivas Pandruvada Signed-off-by: Len Brown --- drivers/cpufreq/intel_pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 4ec5668..4538182 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2031,10 +2031,10 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy) */ intel_pstate_clear_update_util_hook(policy->cpu); intel_pstate_max_within_limits(cpu); + } else { + intel_pstate_set_update_util_hook(policy->cpu); } - intel_pstate_set_update_util_hook(policy->cpu); - if (hwp_active) intel_pstate_hwp_set(policy->cpu);