| Message ID | e7c061535f2dcca54d6498405fdd5ed7098b19f9.1540189330.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v6,1/6] dt-bindings: power: Introduce one property to present the battery internal resistance | expand |
Hi Sebastian, On 22 October 2018 at 15:43, Baolin Wang <baolin.wang@linaro.org> wrote: > The internal resistance of a battery is not a constant in its life cycle, > this varies over the age of the battery or temperature and so on. But we > just want use one constant battery internal resistance to estimate the > battery capacity. Thus this patch introduces one property to present > the battery factory internal resistance for battery information. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > Changes from v5: > - None. > > Changes from v4: > - None. > > Changes from v3: > - Split binding into one separate patch. > - Add LinusW reviewed tag. > > Changes from v2: > - Rename the property. > - Improve the commit message. > > Changes from v1: > - New patch in v2. > --- I think this v6 patch set have addressed your comments on v5, so could you apply this patch set if there are no other comments? I hope this driver can be merged into 4.20 finally. Thanks.
Hi Baolin, On Thu, Oct 25, 2018 at 10:01:55AM +0800, Baolin Wang wrote: > Hi Sebastian, > > On 22 October 2018 at 15:43, Baolin Wang <baolin.wang@linaro.org> wrote: > > The internal resistance of a battery is not a constant in its life cycle, > > this varies over the age of the battery or temperature and so on. But we > > just want use one constant battery internal resistance to estimate the > > battery capacity. Thus this patch introduces one property to present > > the battery factory internal resistance for battery information. > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > Changes from v5: > > - None. > > > > Changes from v4: > > - None. > > > > Changes from v3: > > - Split binding into one separate patch. > > - Add LinusW reviewed tag. > > > > Changes from v2: > > - Rename the property. > > - Improve the commit message. > > > > Changes from v1: > > - New patch in v2. > > --- > > I think this v6 patch set have addressed your comments on v5, so could > you apply this patch set if there are no other comments? I hope this > driver can be merged into 4.20 finally. Thanks. Everything looks fine to me. I will merge this directly after the 4.20 merge window has been closed and linux-next is open again. I'm not merging non-trivial, non-bugfix patches this lates during the release process. -- Sebastian
On 26 October 2018 at 04:13, Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > Hi Baolin, > > On Thu, Oct 25, 2018 at 10:01:55AM +0800, Baolin Wang wrote: >> Hi Sebastian, >> >> On 22 October 2018 at 15:43, Baolin Wang <baolin.wang@linaro.org> wrote: >> > The internal resistance of a battery is not a constant in its life cycle, >> > this varies over the age of the battery or temperature and so on. But we >> > just want use one constant battery internal resistance to estimate the >> > battery capacity. Thus this patch introduces one property to present >> > the battery factory internal resistance for battery information. >> > >> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> > --- >> > Changes from v5: >> > - None. >> > >> > Changes from v4: >> > - None. >> > >> > Changes from v3: >> > - Split binding into one separate patch. >> > - Add LinusW reviewed tag. >> > >> > Changes from v2: >> > - Rename the property. >> > - Improve the commit message. >> > >> > Changes from v1: >> > - New patch in v2. >> > --- >> >> I think this v6 patch set have addressed your comments on v5, so could >> you apply this patch set if there are no other comments? I hope this >> driver can be merged into 4.20 finally. Thanks. > > Everything looks fine to me. I will merge this directly after the > 4.20 merge window has been closed and linux-next is open again. > I'm not merging non-trivial, non-bugfix patches this lates during the > release process. Understood. Thanks Sebastian.
diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt index f4d3b4a..938d027 100644 --- a/Documentation/devicetree/bindings/power/supply/battery.txt +++ b/Documentation/devicetree/bindings/power/supply/battery.txt @@ -22,6 +22,7 @@ Optional Properties: - charge-term-current-microamp: current for charge termination phase - constant-charge-current-max-microamp: maximum constant input current - constant-charge-voltage-max-microvolt: maximum constant input voltage + - factory-internal-resistance-micro-ohms: battery factory internal resistance Battery properties are named, where possible, for the corresponding elements in enum power_supply_property, defined in @@ -42,6 +43,7 @@ Example: charge-term-current-microamp = <128000>; constant-charge-current-max-microamp = <900000>; constant-charge-voltage-max-microvolt = <4200000>; + factory-internal-resistance-micro-ohms = <250000>; }; charger: charger@11 {