[0/3,v2] IMSM autolayout improvements

Message

Mariusz Tkaczyk May 31, 2022, 10:27 a.m. UTC

Following patchset modifies some parts of IMSM creation to ensure that
member's order is always same. It is ISM metadata requirement.

Additionally, as discussed with Jes I've started to implement more modern error
handling, by adding special enum for IMSM. Will be great to hear any comments
and opinion.

V2 improvements:
- typedef added in first patch
- changed order in enum

Mariusz Tkaczyk (3):
  imsm: introduce get_disk_slot_in_dev()
  imsm: use same slot across container
  imsm: block changing slots during creation

 super-intel.c        | 249 ++++++++++++++++++++++++++++---------------
 tests/09imsm-overlap |  28 -----
 2 files changed, 166 insertions(+), 111 deletions(-)
 delete mode 100644 tests/09imsm-overlap

Comments

Coly Li May 31, 2022, 5:53 p.m. UTC | #1

> 2022年5月31日 18:27，Mariusz Tkaczyk <[e-mail]> 写道：
> 
> Following patchset modifies some parts of IMSM creation to ensure that
> member's order is always same. It is ISM metadata requirement.
> 
> Additionally, as discussed with Jes I've started to implement more modern error
> handling, by adding special enum for IMSM. Will be great to hear any comments
> and opinion.
> 
> V2 improvements:
> - typedef added in first patch
> - changed order in enum
> 
> Mariusz Tkaczyk (3):
>  imsm: introduce get_disk_slot_in_dev()
>  imsm: use same slot across container
>  imsm: block changing slots during creation

These patches look fine to me and I ack them all. Next step I will apply them into mdadm-CI 20220406-testing branch (not yet now) for further testing.

Thanks for the update.

Coly Li