mbox series

[v4,mdadm,0/5] mdadm: remove bitmap file support

Message ID 20241202015913.3815936-1-yukuai1@huaweicloud.com (mailing list archive)
Headers show
Series mdadm: remove bitmap file support | expand

Message

Yu Kuai Dec. 2, 2024, 1:59 a.m. UTC
From: Yu Kuai <yukuai3@huawei.com>

Changes in v2:
 - remove patch to support lockless bitmap;

Changes in v3:
 - add patch 4;

Changes in v4:
 - add patch 4 to change behaviour if user doesn't set bitmap;
 - add commit message about external metadata for patch 3;

Yu Kuai (5):
  tests/04update-uuid: remove bitmap file test
  tests/05r1-re-add-nosuper: remove bitmap file test
  Manage: forbid re-add to the array without metadata
  mdadm: ask user if bitmap is not set
  mdadm: remove bitmap file support

 Assemble.c                | 33 +-------------
 Build.c                   | 35 +--------------
 Create.c                  | 48 ++------------------
 Grow.c                    | 94 +++++----------------------------------
 Incremental.c             | 37 +--------------
 Manage.c                  | 12 +++++
 bitmap.c                  | 44 +++++++++---------
 config.c                  | 17 ++++---
 mdadm.c                   | 87 ++++++++++++++++++------------------
 mdadm.h                   | 18 +++++---
 tests/04update-uuid       | 34 --------------
 tests/05r1-re-add-nosuper | 32 +++----------
 12 files changed, 126 insertions(+), 365 deletions(-)

Comments

Mariusz Tkaczyk Dec. 2, 2024, 7:57 a.m. UTC | #1
On Mon,  2 Dec 2024 09:59:08 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - remove patch to support lockless bitmap;
> 
> Changes in v3:
>  - add patch 4;
> 
> Changes in v4:
>  - add patch 4 to change behaviour if user doesn't set bitmap;
>  - add commit message about external metadata for patch 3;
> 

Hi Kuai,
LGTM.

I opened PR to test against our changes:
https://github.com/md-raid-utilities/mdadm/pull/133

If all fine, I will take it and make a release soon!

Thanks,
Mariusz
Mariusz Tkaczyk Dec. 3, 2024, 2:56 p.m. UTC | #2
On Mon,  2 Dec 2024 09:59:08 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - remove patch to support lockless bitmap;
> 
> Changes in v3:
>  - add patch 4;
> 
> Changes in v4:
>  - add patch 4 to change behaviour if user doesn't set bitmap;
>  - add commit message about external metadata for patch 3;
> 

Applied! 

Thanks,
Mariusz