| Message ID | 20241004124227.3540-1-paulluselinux@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | md: CI log retrival test - do not review | expand |
| Context | Check | Description |
|---|---|---|
| mdraidci/vmtest-md-6_12-PR | fail | PR summary |
| mdraidci/vmtest-md-6_12-VM_Test-0 | fail | Logs for per-patch-testing |
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on song-md/md-next] [also build test ERROR on linus/master v6.12-rc1 next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Paul-Luse/md-CI-log-retrival-test-do-not-review/20241004-204420 base: https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next patch link: https://lore.kernel.org/r/20241004124227.3540-1-paulluselinux%40gmail.com patch subject: [PATCH] md: CI log retrival test - do not review config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241007/202410070623.1WRxUPy0-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241007/202410070623.1WRxUPy0-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202410070623.1WRxUPy0-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/md/raid1.c:68:1: error: use of undeclared identifier 'x' 68 | x | ^ 1 error generated. vim +/x +68 drivers/md/raid1.c 54 55 #define START(node) ((node)->start) 56 #define LAST(node) ((node)->last) 57 INTERVAL_TREE_DEFINE(struct serial_info, node, sector_t, _subtree_last, 58 START, LAST, static inline, raid1_rb); 59 60 static int check_and_add_serial(struct md_rdev *rdev, struct r1bio *r1_bio, 61 struct serial_info *si, int idx) 62 { 63 unsigned long flags; 64 int ret = 0; 65 sector_t lo = r1_bio->sector; 66 sector_t hi = lo + r1_bio->sectors; 67 struct serial_in_rdev *serial = &rdev->serial[idx]; > 68 x 69 spin_lock_irqsave(&serial->serial_lock, flags); 70 /* collision happened */ 71 if (raid1_rb_iter_first(&serial->serial_rb, lo, hi)) 72 ret = -EBUSY; 73 else { 74 si->start = lo; 75 si->last = hi; 76 raid1_rb_insert(si, &serial->serial_rb); 77 } 78 spin_unlock_irqrestore(&serial->serial_lock, flags); 79 80 return ret; 81 } 82
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on song-md/md-next] [also build test ERROR on linus/master v6.12-rc1 next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Paul-Luse/md-CI-log-retrival-test-do-not-review/20241004-204420 base: https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next patch link: https://lore.kernel.org/r/20241004124227.3540-1-paulluselinux%40gmail.com patch subject: [PATCH] md: CI log retrival test - do not review config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241007/202410070615.9IATJLEA-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241007/202410070615.9IATJLEA-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202410070615.9IATJLEA-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/md/raid1.c: In function 'check_and_add_serial': >> drivers/md/raid1.c:68:1: error: 'x' undeclared (first use in this function) 68 | x | ^ drivers/md/raid1.c:68:1: note: each undeclared identifier is reported only once for each function it appears in drivers/md/raid1.c:68:2: error: expected ';' before 'do' 68 | x | ^ | ; vim +/x +68 drivers/md/raid1.c 54 55 #define START(node) ((node)->start) 56 #define LAST(node) ((node)->last) 57 INTERVAL_TREE_DEFINE(struct serial_info, node, sector_t, _subtree_last, 58 START, LAST, static inline, raid1_rb); 59 60 static int check_and_add_serial(struct md_rdev *rdev, struct r1bio *r1_bio, 61 struct serial_info *si, int idx) 62 { 63 unsigned long flags; 64 int ret = 0; 65 sector_t lo = r1_bio->sector; 66 sector_t hi = lo + r1_bio->sectors; 67 struct serial_in_rdev *serial = &rdev->serial[idx]; > 68 x 69 spin_lock_irqsave(&serial->serial_lock, flags); 70 /* collision happened */ 71 if (raid1_rb_iter_first(&serial->serial_rb, lo, hi)) 72 ret = -EBUSY; 73 else { 74 si->start = lo; 75 si->last = hi; 76 raid1_rb_insert(si, &serial->serial_rb); 77 } 78 spin_unlock_irqrestore(&serial->serial_lock, flags); 79 80 return ret; 81 } 82
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index f55c8e67d059..e2e97a9e0b73 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -62,7 +62,7 @@ static int check_and_add_serial(struct md_rdev *rdev, struct r1bio *r1_bio, sector_t lo = r1_bio->sector; sector_t hi = lo + r1_bio->sectors; struct serial_in_rdev *serial = &rdev->serial[idx]; - +x spin_lock_irqsave(&serial->serial_lock, flags); /* collision happened */ if (raid1_rb_iter_first(&serial->serial_rb, lo, hi))
Reminder to myself, do not delete the PR as it can be re-used for more testing. Signed-off-by: Paul Luse <paulluselinux@gmail.com> --- drivers/md/raid1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)