| Message ID | 20241105130105.127336-1-yuancan@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | md/md-bitmap: Add missing destroy_work_on_stack() | expand |
| Context | Check | Description |
|---|---|---|
| mdraidci/vmtest-md-6_13-PR | success | PR summary |
| mdraidci/vmtest-md-6_13-VM_Test-0 | success | Logs for per-patch-testing |
在 2024/11/05 21:01, Yuan Can 写道: > This commit add missed destroy_work_on_stack() operations for > unplug_work.work in bitmap_unplug_async(). > > Fixes: a022325ab970 ("md/md-bitmap: add a new helper to unplug bitmap asynchrously") > Signed-off-by: Yuan Can <yuancan@huawei.com> > --- > drivers/md/md-bitmap.c | 1 + > 1 file changed, 1 insertion(+) > LGTM Reviewed-by: Yu Kuai <yukuai3@huawei.com> > diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c > index 29da10e6f703..c3a42dd66ce5 100644 > --- a/drivers/md/md-bitmap.c > +++ b/drivers/md/md-bitmap.c > @@ -1285,6 +1285,7 @@ static void bitmap_unplug_async(struct bitmap *bitmap) > > queue_work(md_bitmap_wq, &unplug_work.work); > wait_for_completion(&done); > + destroy_work_on_stack(&unplug_work.work); > } > > static void bitmap_unplug(struct mddev *mddev, bool sync) >
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c index 29da10e6f703..c3a42dd66ce5 100644 --- a/drivers/md/md-bitmap.c +++ b/drivers/md/md-bitmap.c @@ -1285,6 +1285,7 @@ static void bitmap_unplug_async(struct bitmap *bitmap) queue_work(md_bitmap_wq, &unplug_work.work); wait_for_completion(&done); + destroy_work_on_stack(&unplug_work.work); } static void bitmap_unplug(struct mddev *mddev, bool sync)
This commit add missed destroy_work_on_stack() operations for unplug_work.work in bitmap_unplug_async(). Fixes: a022325ab970 ("md/md-bitmap: add a new helper to unplug bitmap asynchrously") Signed-off-by: Yuan Can <yuancan@huawei.com> --- drivers/md/md-bitmap.c | 1 + 1 file changed, 1 insertion(+)