| Message ID | 2b2cdeac-d052-bd11-a3d6-d82d9b3fe10e@huawei.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | mdadm: fix memory leak and double free | expand |
> 2022年8月2日 10:16，Wu Guanghao <wuguanghao3@huawei.com> 写道： > > When free(super->buf) but not set super->buf = NULL, will be double free > > get_super_block > err = load_and_parse_mpb > load_imsm_mpb(.., s, ..) > if (posix_memalign(&super->buf, MAX_SECTOR_SIZE, super->len) != 0) // true, super->buf != NULL > if (posix_memalign(&super->migr_rec_buf, MAX_SECTOR_SIZE,); // false > free(super->buf); //but super->buf not set NULL > return 2; > > if err ! = 0 > if (s) > free_imsm(s) > __free_imsm(s) > if (s) > free(s->buf); //double free > > Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com> > Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li > --- > super-intel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/super-intel.c b/super-intel.c > index 4ddfcf94..ddbdd3e1 100644 > --- a/super-intel.c > +++ b/super-intel.c > @@ -4510,6 +4510,7 @@ static int load_imsm_mpb(int fd, struct intel_super *super, char *devname) > MIGR_REC_BUF_SECTORS*MAX_SECTOR_SIZE) != 0) { > pr_err("could not allocate migr_rec buffer\n"); > free(super->buf); > + super->buf = NULL; > return 2; > } > super->clean_migration_record_by_mdmon = 0; > -- > 2.27.0
diff --git a/super-intel.c b/super-intel.c index 4ddfcf94..ddbdd3e1 100644 --- a/super-intel.c +++ b/super-intel.c @@ -4510,6 +4510,7 @@ static int load_imsm_mpb(int fd, struct intel_super *super, char *devname) MIGR_REC_BUF_SECTORS*MAX_SECTOR_SIZE) != 0) { pr_err("could not allocate migr_rec buffer\n"); free(super->buf); + super->buf = NULL; return 2; } super->clean_migration_record_by_mdmon = 0;
When free(super->buf) but not set super->buf = NULL, will be double free get_super_block err = load_and_parse_mpb load_imsm_mpb(.., s, ..) if (posix_memalign(&super->buf, MAX_SECTOR_SIZE, super->len) != 0) // true, super->buf != NULL if (posix_memalign(&super->migr_rec_buf, MAX_SECTOR_SIZE,); // false free(super->buf); //but super->buf not set NULL return 2; if err ! = 0 if (s) free_imsm(s) __free_imsm(s) if (s) free(s->buf); //double free Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com> Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> --- super-intel.c | 1 + 1 file changed, 1 insertion(+) -- 2.27.0