[v2,rdma-rc,0/2] RDMA/hns: Some updates for hip08

Message

Yixian Liu Nov. 16, 2018, 3:03 a.m. UTC

This patch set fixed a bug for rereg mr and added the support
of processing AEQ overflow.
---
Changes from v1:
- Withdraw fortify warning related patch [3/3] from v1.

Xiaofei Tan (1):
  RDMA/hns: Add the process of AEQ overflow for hip08

Yixian Liu (1):
  RDMA/hns: Bugfix pbl configuration for rereg mr

 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 139 +++++++++++++++--------------
 1 file changed, 71 insertions(+), 68 deletions(-)

Comments

Jason Gunthorpe Nov. 21, 2018, 9:08 p.m. UTC | #1

On Fri, Nov 16, 2018 at 11:03:08AM +0800, Yixian Liu wrote:
> This patch set fixed a bug for rereg mr and added the support
> of processing AEQ overflow.
> Changes from v1:
> - Withdraw fortify warning related patch [3/3] from v1.
> 
> Xiaofei Tan (1):
>   RDMA/hns: Add the process of AEQ overflow for hip08
> 
> Yixian Liu (1):
>   RDMA/hns: Bugfix pbl configuration for rereg mr
> 
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 139 +++++++++++++++--------------
>  1 file changed, 71 insertions(+), 68 deletions(-)

None of these commit messges are good enough for -rc. Please resend
with proper commit messages.

You must describe the bug this is fixing, and the user impact the bug
has. Please see my past writings to your team on this topic.

Do not say unnecessary and obvious things like 'this patches fixes it'
in the commit messages.

Jason

Yixian Liu Nov. 23, 2018, 7:15 a.m. UTC | #2

On 2018/11/22 5:08, Jason Gunthorpe wrote:
> On Fri, Nov 16, 2018 at 11:03:08AM +0800, Yixian Liu wrote:
>> This patch set fixed a bug for rereg mr and added the support
>> of processing AEQ overflow.
>> Changes from v1:
>> - Withdraw fortify warning related patch [3/3] from v1.
>>
>> Xiaofei Tan (1):
>>   RDMA/hns: Add the process of AEQ overflow for hip08
>>
>> Yixian Liu (1):
>>   RDMA/hns: Bugfix pbl configuration for rereg mr
>>
>>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 139 +++++++++++++++--------------
>>  1 file changed, 71 insertions(+), 68 deletions(-)
> 
> None of these commit messges are good enough for -rc. Please resend
> with proper commit messages.
> 
> You must describe the bug this is fixing, and the user impact the bug
> has. Please see my past writings to your team on this topic.
> 
> Do not say unnecessary and obvious things like 'this patches fixes it'
> in the commit messages.
> 
> Jason

Hi Jason,

Thanks for your advice and sorry for poor commit message.
I will promote my description in later patches.

Thanks.