[V2,for-next,0/8] Refactor control path of bnxt_re driver

Message

Devesh Sharma Jan. 30, 2020, 6:12 p.m. UTC

This is the first series out of few more forthcoming series to refactor
Broadcom's RoCE driver. This series contains patches to refactor control
path. Since this is first series, there may be few code section which may
look redundant or overkill but those will be taken care in future patch
series.

These patches apply clean on tip of for-next branch.
Each patch in this series is tested against user and kernel functionality.

v1->v2
patch 0001
  -- removed unwind logic when qp destroy fails.
  -- removed atomic dec out of mutex lock
patch 0003
  -- saved memset by using default initializer for hwq_attr and sginfo
patch 0004
  -- saved memset by using default initializer for rattr.
patch 0008
  -- a new patch to remove dev_err/dbg/warn/info from driver.

Devesh Sharma (8):
  RDMA/bnxt_re: Refactor queue pair creation code
  RDMA/bnxt_re: Replace chip context structure with pointer
  RDMA/bnxt_re: Refactor hardware queue memory allocation
  RDMA/bnxt_re: Refactor net ring allocation function
  RDMA/bnxt_re: Refactor command queue management code
  RDMA/bnxt_re: Refactor notification queue management code
  RDMA/bnxt_re: Refactor doorbell management functions
  RDMA/bnxt_re: use ibdev based message printing functions

 drivers/infiniband/hw/bnxt_re/bnxt_re.h    |  24 +-
 drivers/infiniband/hw/bnxt_re/ib_verbs.c   | 900 ++++++++++++++++++-----------
 drivers/infiniband/hw/bnxt_re/main.c       | 264 +++++----
 drivers/infiniband/hw/bnxt_re/qplib_fp.c   | 415 ++++++-------
 drivers/infiniband/hw/bnxt_re/qplib_fp.h   |  94 +--
 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 472 +++++++++------
 drivers/infiniband/hw/bnxt_re/qplib_rcfw.h |  85 +--
 drivers/infiniband/hw/bnxt_re/qplib_res.c  | 470 +++++++++------
 drivers/infiniband/hw/bnxt_re/qplib_res.h  | 145 ++++-
 drivers/infiniband/hw/bnxt_re/qplib_sp.c   |  48 +-
 10 files changed, 1739 insertions(+), 1178 deletions(-)

Comments

Jason Gunthorpe Feb. 13, 2020, 8:17 p.m. UTC | #1

On Thu, Jan 30, 2020 at 01:12:54PM -0500, Devesh Sharma wrote:
> This is the first series out of few more forthcoming series to refactor
> Broadcom's RoCE driver. This series contains patches to refactor control
> path. Since this is first series, there may be few code section which may
> look redundant or overkill but those will be taken care in future patch
> series.
> 
> These patches apply clean on tip of for-next branch.
> Each patch in this series is tested against user and kernel functionality.

These don't apply to for-next, please respin them

Applying: RDMA/bnxt_re: Refactor queue pair creation code
Applying: RDMA/bnxt_re: Replace chip context structure with pointer
Applying: RDMA/bnxt_re: Refactor hardware queue memory allocation
Applying: RDMA/bnxt_re: Refactor net ring allocation function
Applying: RDMA/bnxt_re: Refactor command queue management code
Using index info to reconstruct a base tree...
M	drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
CONFLICT (content): Merge conflict in drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

Thanks,
Jason

Devesh Sharma Feb. 14, 2020, 5:24 a.m. UTC | #2

On Fri, Feb 14, 2020 at 1:47 AM Jason Gunthorpe <[e-mail]> wrote:
>
> On Thu, Jan 30, 2020 at 01:12:54PM -0500, Devesh Sharma wrote:
> > This is the first series out of few more forthcoming series to refactor
> > Broadcom's RoCE driver. This series contains patches to refactor control
> > path. Since this is first series, there may be few code section which may
> > look redundant or overkill but those will be taken care in future patch
> > series.
> >
> > These patches apply clean on tip of for-next branch.
> > Each patch in this series is tested against user and kernel functionality.
>
> These don't apply to for-next, please respin them
>
> Applying: RDMA/bnxt_re: Refactor queue pair creation code
> Applying: RDMA/bnxt_re: Replace chip context structure with pointer
> Applying: RDMA/bnxt_re: Refactor hardware queue memory allocation
> Applying: RDMA/bnxt_re: Refactor net ring allocation function
> Applying: RDMA/bnxt_re: Refactor command queue management code
> Using index info to reconstruct a base tree...
> M       drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
> Falling back to patching base and 3-way merge...
> Auto-merging drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
> CONFLICT (content): Merge conflict in drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
>
Oops!! okay I let me resolve this conflict and respin the series.
Thanks
> Thanks,
> Jason