mbox series

[v4,for-next,00/11] RDMA/hns: Updates for 5.11

Message ID 1607608479-54518-1-git-send-email-liweihang@huawei.com (mailing list archive)
Headers show
Series RDMA/hns: Updates for 5.11 | expand

Message

Weihang Li Dec. 10, 2020, 1:54 p.m. UTC 
There are miscellaneous updates for hns driver:
* #1 fixes a potential length issue when copying udata.
* #2 fixes the unreasonable judgment when using HEM of SRQ and SCCC.
* #3 fixes wrong value of Traffic Class.
* #4 and #5 fix issues about Service Level.
* #6 ~ #11 are cleanups, including removing dead code, fixing coding style
  issues and so on.

Changes since v3:
- Avoid an unused variable warning in #10.

Changes since v2:
- Remove WARN_ON() in #5 when filling QPC.

Changes since v1:
- Only do shift on tclass when using RoCEv2 in #3.

Previous version:
v3: https://patchwork.kernel.org/project/linux-rdma/cover/1607606572-11968-1-git-send-email-liweihang@huawei.com/
v2: https://patchwork.kernel.org/project/linux-rdma/cover/1607078436-26455-1-git-send-email-liweihang@huawei.com/
v1: https://patchwork.kernel.org/project/linux-rdma/cover/1606899553-54592-1-git-send-email-liweihang@huawei.com/

Lang Cheng (1):
  RDMA/hns: Fix coding style issues

Weihang Li (3):
  RDMA/hns: Do shift on traffic class when using RoCEv2
  RDMA/hns: Avoid filling sl in high 3 bits of vlan_id
  RDMA/hns: WARN_ON if get a reserved sl from users

Wenpeng Liang (3):
  RDMA/hns: Limit the length of data copied between kernel and userspace
  RDMA/hns: Normalization the judgment of some features
  RDMA/hns: Fix incorrect symbol types

Xinhao Liu (1):
  RDMA/hns: Clear redundant variable initialization

Yixian Liu (2):
  RDMA/hns: Remove unnecessary access right set during INIT2INIT
  RDMA/hns: Simplify AEQE process for different types of queue

Yixing Liu (1):
  RDMA/hns: Fix inaccurate prints

 drivers/infiniband/hw/hns/hns_roce_ah.c     |  13 +--
 drivers/infiniband/hw/hns/hns_roce_alloc.c  |   4 +-
 drivers/infiniband/hw/hns/hns_roce_cmd.c    |  37 +++---
 drivers/infiniband/hw/hns/hns_roce_cmd.h    |   6 +-
 drivers/infiniband/hw/hns/hns_roce_common.h |  14 +--
 drivers/infiniband/hw/hns/hns_roce_cq.c     |  42 +++----
 drivers/infiniband/hw/hns/hns_roce_db.c     |   8 +-
 drivers/infiniband/hw/hns/hns_roce_device.h |  87 ++++++--------
 drivers/infiniband/hw/hns/hns_roce_hem.c    |  44 +++----
 drivers/infiniband/hw/hns/hns_roce_hem.h    |   2 +-
 drivers/infiniband/hw/hns/hns_roce_hw_v1.c  |  41 +++----
 drivers/infiniband/hw/hns/hns_roce_hw_v1.h  |   2 +-
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c  | 172 +++++++++-------------------
 drivers/infiniband/hw/hns/hns_roce_hw_v2.h  |   6 +-
 drivers/infiniband/hw/hns/hns_roce_main.c   |  19 +--
 drivers/infiniband/hw/hns/hns_roce_mr.c     |  25 ++--
 drivers/infiniband/hw/hns/hns_roce_pd.c     |  13 ++-
 drivers/infiniband/hw/hns/hns_roce_qp.c     |  82 +++++++------
 drivers/infiniband/hw/hns/hns_roce_srq.c    |  48 ++++----
 19 files changed, 297 insertions(+), 368 deletions(-)

Comments

Jason Gunthorpe Dec. 11, 2020, 12:16 a.m. UTC | #1 
On Thu, Dec 10, 2020 at 09:54:28PM +0800, Weihang Li wrote:
> There are miscellaneous updates for hns driver:
> * #1 fixes a potential length issue when copying udata.
> * #2 fixes the unreasonable judgment when using HEM of SRQ and SCCC.
> * #3 fixes wrong value of Traffic Class.
> * #4 and #5 fix issues about Service Level.
> * #6 ~ #11 are cleanups, including removing dead code, fixing coding style
>   issues and so on.

Doesn't compile:

In file included from drivers/infiniband/hw/hns/hns_roce_hw_v1.c:40:
drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function ‘set_eq_cons_index_v1’:
drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3606:42: error: ‘struct hns_roce_eq’ has no member named ‘db_reg’
 3606 |          (req_not << eq->log_entries), eq->db_reg);
      |                                          ^~
drivers/infiniband/hw/hns/hns_roce_common.h:39:49: note: in definition of macro ‘roce_raw_write’
   39 |  __raw_writel((__force u32)cpu_to_le32(value), (addr))
      |                                                 ^~~~

Jason
Weihang Li Dec. 11, 2020, 1:27 a.m. UTC | #2 
On 2020/12/11 8:16, Jason Gunthorpe wrote:
> On Thu, Dec 10, 2020 at 09:54:28PM +0800, Weihang Li wrote:
>> There are miscellaneous updates for hns driver:
>> * #1 fixes a potential length issue when copying udata.
>> * #2 fixes the unreasonable judgment when using HEM of SRQ and SCCC.
>> * #3 fixes wrong value of Traffic Class.
>> * #4 and #5 fix issues about Service Level.
>> * #6 ~ #11 are cleanups, including removing dead code, fixing coding style
>>   issues and so on.
> 
> Doesn't compile:
> 
> In file included from drivers/infiniband/hw/hns/hns_roce_hw_v1.c:40:
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function ‘set_eq_cons_index_v1’:
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3606:42: error: ‘struct hns_roce_eq’ has no member named ‘db_reg’
>  3606 |          (req_not << eq->log_entries), eq->db_reg);
>       |                                          ^~
> drivers/infiniband/hw/hns/hns_roce_common.h:39:49: note: in definition of macro ‘roce_raw_write’
>    39 |  __raw_writel((__force u32)cpu_to_le32(value), (addr))
>       |                                                 ^~~~
> 
> Jason
> 

Sorry for that, will fix it later.

Weihang