[for-next,v2,0/2] Fix RMW to bit-fields and remove one superfluous ib_modify_qp

Message

Haakon Bugge June 22, 2021, 1:39 p.m. UTC

This series removes one superfluous ib_modify_qp() when a connected QP
is created through rdma_create_qp(). This commit removes a call to
rdma_init_qp_attr() for connected QPs without holding the qp_mutex.

The second commit tightens the access to bit-fields and synchronizes
the access to them by means of mutex exclusion.

v1 -> v2:
   * Added mutex protection in cma_resolve_iboe_route() for
     timeout/timeout_set in commit ("RDMA/cma: Protect RMW with
     qp_mutex")

Håkon Bugge (2):
  RDMA/cma: Remove unnecessary INIT->INIT transition
  RDMA/cma: Protect RMW with qp_mutex

 drivers/infiniband/core/cma.c | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

--
1.8.3.1

Comments

Jason Gunthorpe June 25, 2021, 1:52 p.m. UTC | #1

On Tue, Jun 22, 2021 at 03:39:55PM +0200, Håkon Bugge wrote:
> This series removes one superfluous ib_modify_qp() when a connected QP
> is created through rdma_create_qp(). This commit removes a call to
> rdma_init_qp_attr() for connected QPs without holding the qp_mutex.
> 
> The second commit tightens the access to bit-fields and synchronizes
> the access to them by means of mutex exclusion.
> 
> v1 -> v2:
>    * Added mutex protection in cma_resolve_iboe_route() for
>      timeout/timeout_set in commit ("RDMA/cma: Protect RMW with
>      qp_mutex")
> 
> Håkon Bugge (2):
>   RDMA/cma: Remove unnecessary INIT->INIT transition
>   RDMA/cma: Protect RMW with qp_mutex

Applied to for-next, thanks

Jason