From patchwork Fri Nov 9 22:07:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 10676617 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 747D213B0 for ; Fri, 9 Nov 2018 22:10:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 689EB2F2EA for ; Fri, 9 Nov 2018 22:10:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D87B2F306; Fri, 9 Nov 2018 22:10:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EADA32F2F7 for ; Fri, 9 Nov 2018 22:10:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728509AbeKJHvT (ORCPT ); Sat, 10 Nov 2018 02:51:19 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:15073 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728468AbeKJHvT (ORCPT ); Sat, 10 Nov 2018 02:51:19 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AD4E020D40163; Sat, 10 Nov 2018 06:08:43 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.226.54) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.408.0; Sat, 10 Nov 2018 06:08:35 +0800 From: Salil Mehta To: CC: , , , , , , , , , , Subject: [RFC PATCH 00/10] net: hns3: Adds support of debugfs to HNS3 driver Date: Fri, 9 Nov 2018 22:07:33 +0000 Message-ID: <20181109220743.10264-1-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 MIME-Version: 1.0 X-Originating-IP: [10.202.226.54] X-CFilter-Loop: Reflected Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patchset adds support of debugfs to the HNS3 driver. Support has been added to query info related to below items: 1. Queue related 2. Flow Director 3. Promisc mode 4. TC config 5. Transmit Module/Scheduler 6. Checksum 7. QoS buffer 8. QoS prio map Note: This patch-set has been floated as an RFC as it is an an effort to understand what type information can be fetched from the kernel and how it can be exported to user-space in the HNS3 driver. There are few questions revolving our minds like, 1. Is it allowed to dump the information of register in the syslog using the printk or we should use debugfs to export information to user-space using file interface only? 2. Can we export the information from the firmware to the userspace using debugfs? 3. Debugfs looks more unstructured unlike sysfs. Is there any de-facto standard of the user-api or drivers are allowed to use it in any way to expose the information from kernel. 4. Last but not least, is there any good driver reference within kernel which can be used as a reference. We could see Intel IXGBE/i40e/mellanox drivers having debugfs interface but with some discussions it looked they have some of the *might be* objectionable implementations. 5. With the idea started from Greg KH original patch Link: https://lwn.net/Articles/115282/ Is the heart-and-soul of debugfs i.e. the reason why it was created still the same? It would be a great help if people can help in throwing light and reviewing this patch-set. Thanks! liuzhongzhu (10): net: hns3: Add debugfs framework registration net: hns3: Add "queue info" query function net: hns3: Add "FD flow table" info query function net: hns3: Add "promisc mode" config info query function net: hns3: Add "tc config" info query function net: hns3: Add "tm config" info query function net: hns3: Add checksum info query function net: hns3: Add PFC config info query function net: hns3: Add "qos prio map" info query function net: hns3: Add "qos buffer" config info query function drivers/net/ethernet/hisilicon/hns3/Makefile | 2 +- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 264 +++++++++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 17 +- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 4 + .../net/ethernet/hisilicon/hns3/hns3pf/Makefile | 2 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 4 + .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 589 +++++++++++++++++++++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h | 24 + .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 6 + 12 files changed, 912 insertions(+), 4 deletions(-) create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h