[0/8] IB: cleanup debugfs usage

Message

Greg KH Jan. 22, 2019, 3:17 p.m. UTC

When calling debugfs code, there is no need to ever check the return
value of the call, as no logic should ever change if a call works
properly or not.  Fix up a bunch of infiniband-specific code to not care
about the results of debugfs.

Greg Kroah-Hartman (8):
  infiniband: cxgb4: no need to check return value of debugfs_create functions
  infiniband: hfi1: drop crazy DEBUGFS_SEQ_FILE_CREATE() macro
  infiniband: hfi1: no need to check return value of debugfs_create functions
  infiniband: qib: no need to check return value of debugfs_create functions
  infiniband: mlx5: no need to check return value of debugfs_create functions
  infiniband: ocrdma: no need to check return value of debugfs_create functions
  infiniband: usnic: no need to check return value of debugfs_create functions
  infiniband: ipoib: no need to check return value of debugfs_create functions

 drivers/infiniband/hw/cxgb4/device.c        |  8 +--
 drivers/infiniband/hw/hfi1/debugfs.c        | 52 +++++++---------
 drivers/infiniband/hw/hfi1/debugfs.h        | 12 ----
 drivers/infiniband/hw/hfi1/fault.c          | 53 ++++++----------
 drivers/infiniband/hw/mlx5/cong.c           | 15 ++---
 drivers/infiniband/hw/mlx5/main.c           |  8 +--
 drivers/infiniband/hw/mlx5/mlx5_ib.h        |  8 +--
 drivers/infiniband/hw/mlx5/mr.c             | 51 +++-------------
 drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 67 +++++++--------------
 drivers/infiniband/hw/qib/qib_debugfs.c     | 26 +++-----
 drivers/infiniband/hw/usnic/usnic_debugfs.c | 26 --------
 drivers/infiniband/ulp/ipoib/ipoib.h        |  4 +-
 drivers/infiniband/ulp/ipoib/ipoib_fs.c     |  7 +--
 drivers/infiniband/ulp/ipoib/ipoib_main.c   |  4 +-
 14 files changed, 94 insertions(+), 247 deletions(-)

Comments

Jason Gunthorpe Jan. 23, 2019, 9:15 p.m. UTC | #1

On Tue, Jan 22, 2019 at 04:17:52PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs code, there is no need to ever check the return
> value of the call, as no logic should ever change if a call works
> properly or not.  Fix up a bunch of infiniband-specific code to not care
> about the results of debugfs.
> 
> Greg Kroah-Hartman (8):
>   infiniband: cxgb4: no need to check return value of debugfs_create functions
>   infiniband: hfi1: drop crazy DEBUGFS_SEQ_FILE_CREATE() macro
>   infiniband: hfi1: no need to check return value of debugfs_create functions
>   infiniband: qib: no need to check return value of debugfs_create functions
>   infiniband: mlx5: no need to check return value of debugfs_create functions
>   infiniband: ocrdma: no need to check return value of debugfs_create functions
>   infiniband: usnic: no need to check return value of debugfs_create functions
>   infiniband: ipoib: no need to check return value of debugfs_create functions

Applied to rdma for-next

Thanks,
Jason