mbox series

[0/7] RDMA/cm: Remove open coded structure pack/unpack

Message ID 20200116170037.30109-1-jgg@ziepe.ca (mailing list archive)
Headers show
Series RDMA/cm: Remove open coded structure pack/unpack | expand

Message

Jason Gunthorpe Jan. 16, 2020, 5 p.m. UTC
From: Jason Gunthorpe <jgg@mellanox.com>

Instead of using a struct layout with a large number of open coded pack/unpack
inlines use a consistent set of macros generating GENMASK's for accessing the
members. The definitions follow the MAD layout tables in the IBA and are easier
to correlate with the specification.

Further the macros consistently use cpu endian values which will allow later
patches to remove alot of the __be stuff sprinkled randomly around.

The is a follow up to the series here:

https://lore.kernel.org/r/20191212093830.316934-1-leon@kernel.org

Jason Gunthorpe (6):
  RDMA/cm: Add accessors for CM_REQ transport_type
  RDMA/cm: Use IBA functions for simple get/set acessors
  RDMA/cm: Use IBA functions for swapping get/set acessors
  RDMA/cm: Use IBA functions for simple structure members
  RDMA/cm: Use IBA functions for complex structure members
  RDMA/cm: Remove CM message structs

Leon Romanovsky (1):
  RDMA/cm: Add SET/GET implementations to hide IBA wire format

 drivers/infiniband/core/cm.c      | 793 ++++++++++++++++++------------
 drivers/infiniband/core/cm_msgs.h | 685 +-------------------------
 include/rdma/iba.h                | 146 ++++++
 include/rdma/ibta_vol1_c12.h      | 213 ++++++++
 4 files changed, 852 insertions(+), 985 deletions(-)
 create mode 100644 include/rdma/iba.h
 create mode 100644 include/rdma/ibta_vol1_c12.h

Comments

Jason Gunthorpe Jan. 25, 2020, 7:24 p.m. UTC | #1
On Thu, Jan 16, 2020 at 01:00:30PM -0400, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
> 
> Instead of using a struct layout with a large number of open coded pack/unpack
> inlines use a consistent set of macros generating GENMASK's for accessing the
> members. The definitions follow the MAD layout tables in the IBA and are easier
> to correlate with the specification.
> 
> Further the macros consistently use cpu endian values which will allow later
> patches to remove alot of the __be stuff sprinkled randomly around.
> 
> The is a follow up to the series here:
> 
> https://lore.kernel.org/r/20191212093830.316934-1-leon@kernel.org
> 
> Jason Gunthorpe (6):
>   RDMA/cm: Add accessors for CM_REQ transport_type
>   RDMA/cm: Use IBA functions for simple get/set acessors
>   RDMA/cm: Use IBA functions for swapping get/set acessors
>   RDMA/cm: Use IBA functions for simple structure members
>   RDMA/cm: Use IBA functions for complex structure members
>   RDMA/cm: Remove CM message structs
> 
> Leon Romanovsky (1):
>   RDMA/cm: Add SET/GET implementations to hide IBA wire format

Applied to for-next

Jason