[v2,for-rc,0/3] Fixes for 64K page size support

Message

Shiraz Saleem Nov. 29, 2023, 8:21 p.m. UTC

This is a three patch series.

The first core hunk corrects the core iterator to use __sg_advance to skip
preceding 4k HCA pages.

The second patch corrects an iWarp issue where the SQ must be PAGE_SIZE
aligned.

The third patch corrects an issue with the RDMA driver use of
ib_umem_find_best_pgsz(). QP and CQ allocations pass PAGE_SIZE as the
only bitmap bit. This is incorrect and should use the precise 4k value.

v1->v2: Add a umem specific block iter next function

Mike Marciniszyn (3):
  RDMA/core: Fix umem iterator when PAGE_SIZE is greater then HCA pgsz
  RDMA/irdma: Ensure iWarp QP queue memory is OS paged aligned
  RDMA/irdma: Fix support for 64k pages

 drivers/infiniband/core/umem.c      | 6 ------
 drivers/infiniband/hw/irdma/verbs.c | 7 ++++++-
 include/rdma/ib_umem.h              | 9 ++++++++-
 include/rdma/ib_verbs.h             | 1 +
 4 files changed, 15 insertions(+), 8 deletions(-)

Comments

Jason Gunthorpe Dec. 4, 2023, 11:54 p.m. UTC | #1

On Wed, Nov 29, 2023 at 02:21:40PM -0600, Shiraz Saleem wrote:
> This is a three patch series.
> 
> The first core hunk corrects the core iterator to use __sg_advance to skip
> preceding 4k HCA pages.
> 
> The second patch corrects an iWarp issue where the SQ must be PAGE_SIZE
> aligned.
> 
> The third patch corrects an issue with the RDMA driver use of
> ib_umem_find_best_pgsz(). QP and CQ allocations pass PAGE_SIZE as the
> only bitmap bit. This is incorrect and should use the precise 4k value.
> 
> v1->v2: Add a umem specific block iter next function
> 
> Mike Marciniszyn (3):
>   RDMA/core: Fix umem iterator when PAGE_SIZE is greater then HCA pgsz
>   RDMA/irdma: Ensure iWarp QP queue memory is OS paged aligned
>   RDMA/irdma: Fix support for 64k pages

Applied to for-rc, thanks

Jason