mbox series

[v3,net,0/2] tcp/rds: Fix use-after-free around kernel TCP reqsk.

Message ID 20240306230458.28784-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series tcp/rds: Fix use-after-free around kernel TCP reqsk. | expand

Message

Kuniyuki Iwashima March 6, 2024, 11:04 p.m. UTC 
syzkaller reported an warning of netns ref tracker for RDS per-netns
TCP listener, which commit 740ea3c4a0b2 ("tcp: Clean up kernel listener's
reqsk in inet_twsk_purge()") fixed for per-netns ehash.

This series fixes the bug in the partial fix and fixes the bug in the
global ehash.


Changes:
  v3:
    * Drop patch 2, 3, 5
    * Fix UAF by purging reqsk during netns dismantle.

  v2: https://lore.kernel.org/netdev/20240227011041.97375-1-kuniyu@amazon.com/
    * Add patch 1, 3, 5
    * Use __sock_create() instead of converting socket
    * Drop Sowmini from CC as it's bounced (patchwork may complain)

  v1: https://lore.kernel.org/netdev/20240223172448.94084-1-kuniyu@amazon.com/


Kuniyuki Iwashima (2):
  tcp: Restart iteration after removing reqsk in inet_twsk_purge().
  rds: tcp: Fix use-after-free of net in reqsk_timer_handler().

 net/ipv4/inet_timewait_sock.c | 4 +++-
 net/ipv4/tcp_minisocks.c      | 4 ----
 2 files changed, 3 insertions(+), 5 deletions(-)