mbox series

[v4,net,0/2] tcp/rds: Fix use-after-free around kernel TCP reqsk.

Message ID 20240307232151.55963-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series tcp/rds: Fix use-after-free around kernel TCP reqsk. | expand

Message

Kuniyuki Iwashima March 7, 2024, 11:21 p.m. UTC 
syzkaller reported an warning of netns ref tracker for RDS TCP listener,
which commit 740ea3c4a0b2 ("tcp: Clean up kernel listener's reqsk in
inet_twsk_purge()") fixed for per-netns ehash.

This series fixes the bug in the partial fix and fixes the reported bug
in the global ehash.


Changes:
  v4:
    * Add sk_family/refcnt check in inet_twsk_purge().

  v3: https://lore.kernel.org/netdev/20240307224423.53315-1-kuniyu@amazon.com/
    * Drop patch 2, 3, 5
    * Fix uaf by iterating ehash and purging reqsk during netns dismantle.

  v2: https://lore.kernel.org/netdev/20240227011041.97375-1-kuniyu@amazon.com/
    * Add patch 1, 3, 5
    * Use __sock_create() instead of converting socket
    * Drop Sowmini from CC as it's bounced (patchwork may complain)

  v1: https://lore.kernel.org/netdev/20240223172448.94084-1-kuniyu@amazon.com/


Kuniyuki Iwashima (2):
  tcp: Fix use-after-free in inet_twsk_purge().
  rds: tcp: Fix use-after-free of net in reqsk_timer_handler().

 net/ipv4/inet_timewait_sock.c | 24 +++++++++++++++++++-----
 net/ipv4/tcp_minisocks.c      |  4 ----
 2 files changed, 19 insertions(+), 9 deletions(-)