From patchwork Wed Jun 26 10:26:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dragos Tatulea X-Patchwork-Id: 13712565 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F81116089A; Wed, 26 Jun 2024 10:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397626; cv=fail; b=rWVeGZKk9K5N+9FjE7qsYDuiCoBoDAhjwHjvyHdq458LnxrysuN43TqgZ4EfbQwMs5PQs5jb1sJE9MNhQ3veC5F9n0crRuLV02t28aRRKNVaEHcJrZyctbykbRlIQzHChZWC28unBeIfYiRN4IbAIl6DwzTy7Z4584PpDgtE4HI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719397626; c=relaxed/simple; bh=0aAoj28BtZ4IW5jsHbQB0qNP0ucM6tR8jcjCtQOLpIE=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type:To:CC; b=bDuTA0iQQpy03WL7+SNbc6mYDIJgnFvOVSZlZ7v/pnn/168IrJM2M+Aa2+g7Nxc6/QgkbL8CY+KWTUqZAaYfguv5FJrJR48zkybcKxAYM4X4hw5CS7BOC+Zvo1hKihXegTtTZrhVSyTm8kS9EfHjktxclIe0mPvNlyRUoBgxP98= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FXvgXEWV; arc=fail smtp.client-ip=40.107.244.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FXvgXEWV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLAEUdjkqu/kzUyiRPcmVlAGPp+Qg/b4BT7ka6uWXEzU4FQw26xWA6Gl+USD2vEfPXBIiE1aq1XRumKOOaOGIHwx9i3TeSENpqDr0DqL02kMGrrXQ6or9bBMCDcco8rOqe8fmqZDqiG8uNmwd3SysutxauUbO/hMh77zaSFncZ3INR9iNF2kwdeCd7UNzGHLnEA98eY7FkIJHYrzzLeugwoQJYWr5PmJGNRNdBoVEfeLimwb7NjX2z3NgJav1AdAmXQY9U00+VVqzur73WlzBGHtt3ThU5sg5iJs+lH3hkE6xqMFjF4OQxO8reJPo7DvPhYtLK1rh8bfPY9lwUBkPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UeSRcQz++9NrVy0jjK6A4BzJp/ctZweA7pwBZRIjUo0=; b=PAtEBfExwO/dRzdalXWTzzOmmxYjNZSAkYJdvwim6dbN7Mhnd1+4YUK/nwgsojHggaFYCUo8IhLJ3IkbIGxDsgnQw/FcPe8W2CFX1MpjHnxfm0FH+poXwDzb6lu0sIe+QRh9mqbemgEBmuwnLv5irjrQfloaJUxH8SeN8odnrXDL/OCKNTqmKeV+l0x+nsum+2/QaSQ3ZPEqGbZoHXTXzxDBSc3dcNsdenBTJ6giMJ26PS61+78U7PBUMK+9sSSXiTMZ478J2kopCtD+dYg/4E7W4ME+Rf5/7b9Dhzk433J1BWDaloGg67PjT5arT1q9Tcc9ghsIV0Du5BjN+U4OzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UeSRcQz++9NrVy0jjK6A4BzJp/ctZweA7pwBZRIjUo0=; b=FXvgXEWVTXgFNMV0fAvVt7YR772xQfbx+QoasqcizT+KaSXtpkdjlSJRY0738uo43vfonNQLwXtstwpvm9GH4RytFNOUFs0svQE6GwH1cSmmm7K3yjA6AIeeuXltkSAmOJ6sGtkP++Y6s+SllBVRYJleQMjAdUVb3H9x+M0CXT9sDfuNF2kVMHUZiXPfGk0XqBYD7/qaTT8H3ms/PIf+Ly3l5Efa9miNS5JBOg1aWmigdSziJgc6zg9UhxyAlnnbU13sbqCkpwbAm/KW1mHhwBpcK3u5W6Og/GKmMN/AKlOGLmCOMoEJda4DDQNppSKf9p/oWe3NEJOj+paQFDjygA== Received: from SJ0PR13CA0141.namprd13.prod.outlook.com (2603:10b6:a03:2c6::26) by DS0PR12MB9039.namprd12.prod.outlook.com (2603:10b6:8:de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.32; Wed, 26 Jun 2024 10:27:01 +0000 Received: from SJ5PEPF000001C9.namprd05.prod.outlook.com (2603:10b6:a03:2c6:cafe::24) by SJ0PR13CA0141.outlook.office365.com (2603:10b6:a03:2c6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Wed, 26 Jun 2024 10:27:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001C9.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Wed, 26 Jun 2024 10:27:01 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:26:47 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Jun 2024 03:26:46 -0700 Received: from dev-l-177.mtl.labs.mlnx (10.127.8.11) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Wed, 26 Jun 2024 03:26:43 -0700 From: Dragos Tatulea Subject: [PATCH vhost v2 00/24] vdpa/mlx5: Pre-create HW VQs to reduce LM downtime Date: Wed, 26 Jun 2024 13:26:36 +0300 Message-ID: <20240626-stage-vdpa-vq-precreate-v2-0-560c491078df@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIANzse2YC/4WNQQ7CMAwEv1L5jFESSltx4h+oB5O41AcaSCILV PXvRP0Ax9nVzq6QOQlnuDQrJFbJEpcK7tCAn2l5MEqoDM641nS2x1yohhpehPrGV2KfmApj34X Jnu2dgxmgrmszyWc330DnmAuMNZ4ll5i++5/avfyrVosGB2/a4TQZT46ui0oQOvr4hHHbth+xI fm3xgAAAA== To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Si-Wei Liu CC: , , , , Cosmin Ratiu , Dragos Tatulea , Zhu Yanjun X-Mailer: b4 0.13.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C9:EE_|DS0PR12MB9039:EE_ X-MS-Office365-Filtering-Correlation-Id: 41c7d58c-b7fc-4322-f2eb-08dc95ca8444 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|36860700011|376012|7416012|1800799022|82310400024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?r8X3UZadT99LDuPmqQs1Z+ZopC+nkOG?= =?utf-8?q?RzRDmrCbIkJ/C3ZTdE2eOyZRx1MFPHLbjf1svvoB+s7pCcGOnJ78NpX5eF76GHp+I?= =?utf-8?q?3AyyM76BZQAIT8sx2MkMJtHs1JqDXrIL640UyVo87eEJRHTlZz9EoaVmxaOqnxr8+?= =?utf-8?q?opyenGXvyoY4vpLyWwoiGt/ZYVmiNUBF2rgLRaNJ7D+duzXvbBLRrj9PHHBr2aEl6?= =?utf-8?q?96SHIWwvwQpp4jM9RvRalOVdaZICcUCvBEgsX/hHO5Srud5A3mA08+s6idcx7BUCq?= =?utf-8?q?DYulOEqpwKahxYp4674fZ+e9ctnVACyIwQGpRaZNrNOzGuw01+J29d5mvlFJoTvUi?= =?utf-8?q?YE4fNOcGppk3atCz/SMDqPIU9giRt/CTABZRWVjsyl1iDwUzGdTQ3iOgfFB7yhZrN?= =?utf-8?q?zpljrohy+rOrPne4sQAsy9bBiX0lrysPrvJNuXEK3qoYZLCD8CldAd+s6f5a6qKlq?= =?utf-8?q?g5b4BF1FUFOZ3G15vlrRRAXmK/33II9wu/dV7q1FYi1Oo7RhzzFpQeKRuBdzxPFy0?= =?utf-8?q?0EkiUFYMsloc8lMAOQtT/fVCSopM5Ugr+QGLgY0mufZZem7ocE3l4Dxx3CGDwj0iX?= =?utf-8?q?VkWpG9EIQ6uylEAo2RawFGKh8pptfzNnRxFqgEfgK08LFjKHUclRcMqqEFSXISVJq?= =?utf-8?q?9BFmb8WBysyNw8OZeLqwY0OYiUi2VHOb5YDlPCnqIxQXuKw9lihhwgsrFYWSeKu4s?= =?utf-8?q?9jL8B4ZCKfHva11eDGYMz+EMiUTfrSnf5I3GA1Pd9558MKs34vTIHlcr/XMSf9ev/?= =?utf-8?q?ta9jsLlHz9xO3aIUG5tsHiY4yWLPzGYxMGww+fCDe6i8ncmsORwCxUhbX40sUOKZh?= =?utf-8?q?sb/cUzBvG9pLjO7rG2ZZHcRacLCGDSqwkGxhF/FVvkrezxBx2zyjC4Yg+qkzyx6Z7?= =?utf-8?q?o2V56XyahHvUHxN3NyHBE4+z0eDO+savsM8dmTrjSVmogANwFu0wtgMsuQ5lL7Bfn?= =?utf-8?q?VypCKaAAzijCah+QGxpNRk+zFQmr8BHL9WQjd77mmuuCKZ5Xxz+u9LKzgwaJmOenE?= =?utf-8?q?PSfbx5sHazTTzcfJwJ0BX50MepUFUYtr5Z4B1K8gMclIGqV1JMuiOBzRo1YLEEICY?= =?utf-8?q?TzbYy8+uRK0lJuMAX6QTiHzBKUDoFrvOHOenC+6I136mLXHY1kCWCNK9xUR0QUAT+?= =?utf-8?q?3IyfBUiLAIES7RaK/YFjIA0tIKt9OzIWVSGkma8d3HC7SzLGdiCaPwoBxk80BVkVo?= =?utf-8?q?lQbgVXyKRTJgKB582WeqsVNdn2m8702ToKa8ZPW4NyUEnrGNRetX2KrsaOGfyAIc8?= =?utf-8?q?lrrx9yc9HVsZzhK6i9VVKwjrd1a57OzsTf3MbgnAZ0ikHQ/XqRhSfVNViKg0hTcDF?= =?utf-8?q?MIuWLKQ9q0oWTYN2qral/1NdJYPxqYfsTjHDKRrGZFm2mpi2m/3uTORaKxGA7TiVu?= =?utf-8?q?xxsYhKSYYO3x9wVuRNco/UDxQ+Vd0tM5g=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230038)(36860700011)(376012)(7416012)(1800799022)(82310400024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 10:27:01.3561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41c7d58c-b7fc-4322-f2eb-08dc95ca8444 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9039 According to the measurements for vDPA Live Migration downtime [0], one large source of downtime is the creation of hardware VQs and their associated resources on the devices on the destination VM. Previous series ([1], [2]) addressed the source part of the Live Migration downtime. This series addresses the destination part: instead of creating hardware VQs and their dependent resources when the device goes into the DRIVER_OK state (which is during downtime), create "blank" VQs at device creation time and only modify them to the received configuration before starting the VQs (DRIVER_OK state). The caveat here is that mlx5_vdpa VQs don't support modifying the VQ size. VQs will be created with a convenient default size and when this size is changed, they will be recreated. The beginning of the series consists of refactorings and preparation. After that, some preparations are made: - Allow creation of "blank" VQs by not configuring them during create_virtqueue() if there are no modified fields. - The VQ Init to Ready state transition is consolidated into the resume_vq(). - Add error handling to suspend/resume code paths. Then VQs are created at device creation time. Finally, the special cases that need full VQ resource recreation are handled. On a 64 CPU, 256 GB VM with 1 vDPA device of 16 VQps, the full VQ resource creation + resume time was ~370ms. Now it's down to 60 ms (only VQ config and resume). The measurements were done on a ConnectX6DX based vDPA device. [0] https://lore.kernel.org/qemu-devel/1701970793-6865-1-git-send-email-si-wei.liu@oracle.com/ [1] https://lore.kernel.org/lkml/20231018171456.1624030-2-dtatulea@nvidia.com [2] https://lore.kernel.org/lkml/20231219180858.120898-1-dtatulea@nvidia.com --- Changes in v2: - Renamed a function based on v1 review. - Addressed small nits from v1 review. - Added improvement numbers in commit message instead of only cover letter. - Link to v1: https://lore.kernel.org/r/20240617-stage-vdpa-vq-precreate-v1-0-8c0483f0ca2a@nvidia.com --- Dragos Tatulea (24): vdpa/mlx5: Clarify meaning thorough function rename vdpa/mlx5: Make setup/teardown_vq_resources() symmetrical vdpa/mlx5: Drop redundant code vdpa/mlx5: Drop redundant check in teardown_virtqueues() vdpa/mlx5: Iterate over active VQs during suspend/resume vdpa/mlx5: Remove duplicate suspend code vdpa/mlx5: Initialize and reset device with one queue pair vdpa/mlx5: Clear and reinitialize software VQ data on reset vdpa/mlx5: Rename init_mvqs vdpa/mlx5: Add support for modifying the virtio_version VQ field vdpa/mlx5: Add support for modifying the VQ features field vdpa/mlx5: Set an initial size on the VQ vdpa/mlx5: Start off rqt_size with max VQPs vdpa/mlx5: Set mkey modified flags on all VQs vdpa/mlx5: Allow creation of blank VQs vdpa/mlx5: Accept Init -> Ready VQ transition in resume_vq() vdpa/mlx5: Add error code for suspend/resume VQ vdpa/mlx5: Consolidate all VQ modify to Ready to use resume_vq() vdpa/mlx5: Forward error in suspend/resume device vdpa/mlx5: Use suspend/resume during VQP change vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time vdpa/mlx5: Re-create HW VQs under certain conditions vdpa/mlx5: Don't reset VQs more than necessary vdpa/mlx5: Don't enable non-active VQs in .set_vq_ready() drivers/vdpa/mlx5/net/mlx5_vnet.c | 429 +++++++++++++++++++++++++------------ drivers/vdpa/mlx5/net/mlx5_vnet.h | 1 + include/linux/mlx5/mlx5_ifc_vdpa.h | 2 + 3 files changed, 293 insertions(+), 139 deletions(-) --- base-commit: c8fae27d141a32a1624d0d0d5419d94252824498 change-id: 20240617-stage-vdpa-vq-precreate-76df151bed08 Best regards,