| Message ID | 20250207194931.1569-1-tatyana.e.nikolova@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add RDMA support for Intel IPU E2000 (GEN3) | expand |
On 2/7/25 20:49, Tatyana Nikolova wrote: > This patch series is based on 6.14-rc1 and includes both netdev and RDMA > patches for ease of review. It can also be viewed here [1]. A shared pull > request will be sent for patches 1-7 following review. > [...] TLDR of my mail: could be take 1st patch prior to the rest? > V2 RFC series is at https://lwn.net/Articles/987141/. code there was mostly the same, and noone commented, I bet due to the sheer size of the series > 58 files changed, 6693 insertions(+), 1137 deletions(-) While it is very good to have a common cover letter and all the changes available for inspection/cross reference, it is just too much for doing a practical review. I think it would be much easier to follow and split into multiple series if we will apply the first patch, is that feasible now? (It was a no-no back when there were no idpf at all, no it is not a theoretical case anymore, and the patch makes code better anyway)? The first patch: Dave Ertman (1): iidc/ice/irdma: Update IDC to support multiple consumers @Tatyana The rest of the patches needs to go via our internal e1000 ML, and get the Reviewed-by tag prior to being ready for wider review (now the community would have to put substantial effor to get rid of style distractions, etc, and, as we have seen, there was not much eagerness to do that for your RFC v2).
On Mon, Feb 10, 2025 at 11:41:31AM +0100, Przemek Kitszel wrote: > On 2/7/25 20:49, Tatyana Nikolova wrote: > > This patch series is based on 6.14-rc1 and includes both netdev and RDMA > > patches for ease of review. It can also be viewed here [1]. A shared pull > > request will be sent for patches 1-7 following review. > > > > [...] > TLDR of my mail: could be take 1st patch prior to the rest? > > > V2 RFC series is at https://lwn.net/Articles/987141/. > > code there was mostly the same, and noone commented, I bet due > to the sheer size of the series It was very optimistic to expect for a review during holiday season and merge window, especially series of 25 patches which are marked as RFC. Thanks
On 2/10/25 12:09, Leon Romanovsky wrote: > On Mon, Feb 10, 2025 at 11:41:31AM +0100, Przemek Kitszel wrote: >> On 2/7/25 20:49, Tatyana Nikolova wrote: >>> This patch series is based on 6.14-rc1 and includes both netdev and RDMA >>> patches for ease of review. It can also be viewed here [1]. A shared pull >>> request will be sent for patches 1-7 following review. >>> >> >> [...] >> TLDR of my mail: could be take 1st patch prior to the rest? >> >>> V2 RFC series is at https://lwn.net/Articles/987141/. >> >> code there was mostly the same, and noone commented, I bet due >> to the sheer size of the series > > It was very optimistic to expect for a review during holiday season > and merge window, especially series of 25 patches which are marked > as RFC. that's true so, given most of the patches will go via your tree, how do you want to split us the existing ones into series? a) 1st, idpf, rdma b) 1st, rest c) all together In any case I will do a review too of course > > Thanks
On Thu, Feb 13, 2025 at 05:12:46PM +0100, Przemek Kitszel wrote: > On 2/10/25 12:09, Leon Romanovsky wrote: > > On Mon, Feb 10, 2025 at 11:41:31AM +0100, Przemek Kitszel wrote: > > > On 2/7/25 20:49, Tatyana Nikolova wrote: > > > > This patch series is based on 6.14-rc1 and includes both netdev and RDMA > > > > patches for ease of review. It can also be viewed here [1]. A shared pull > > > > request will be sent for patches 1-7 following review. > > > > > > > > > > [...] > > > TLDR of my mail: could be take 1st patch prior to the rest? > > > > > > > V2 RFC series is at https://lwn.net/Articles/987141/. > > > > > > code there was mostly the same, and noone commented, I bet due > > > to the sheer size of the series > > > > It was very optimistic to expect for a review during holiday season > > and merge window, especially series of 25 patches which are marked > > as RFC. > > that's true > > so, given most of the patches will go via your tree, how do you want > to split us the existing ones into series? > > a) 1st, idpf, rdma > b) 1st, rest > c) all together > > In any case I will do a review too of course There is a need to get Acks for the netdev part and because that part is going to be before RDMA patches, the fist option is proffered one. If you plan to merge everything in this cycle, netdev and RDMA parts need to be merged into some shared branch based on clean -rcX. I can do it for you as well, but first need to get Acks for netdev part. Thanks > > > > > Thanks > >