| Message ID | 009669cfad50beb10b3f63434863de231c6b408e.1526414283.git.dledford@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 5/15/2018 3:59 PM, Doug Ledford wrote: > A recent patch set to rework the usage of debugfs and to add fault > injection capabilities via debugfs files to the hfi1 driver introduced a > build error that only shows up when debugfs is fully disabled. The > patchset mistakenly defines some empty stub functions in two different > headers when debugfs is disabled. Remove the set that shouldn't have > been there to resolve the issue. > > Fixes: a74d5307caba ("IB/hfi1: Rework fault injection machinery") > Signed-off-by: Doug Ledford <dledford@redhat.com> DOH! Thanks for fixing that up. I'm kinda surprised that 0-day builds didn't catch it on our end before posting. Oh well, egg on our face I guess. Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/hfi1/debugfs.h b/drivers/infiniband/hw/hfi1/debugfs.h index 1c91461b108f..d5d824459fcc 100644 --- a/drivers/infiniband/hw/hfi1/debugfs.h +++ b/drivers/infiniband/hw/hfi1/debugfs.h @@ -118,21 +118,6 @@ static inline void hfi1_dbg_init(void) static inline void hfi1_dbg_exit(void) { } - -static inline bool hfi1_dbg_should_fault_rx(struct hfi1_packet *packet) -{ - return false; -} - -static inline bool hfi1_dbg_should_fault_tx(struct rvt_qp *qp, u32 opcode) -{ - return false; -} - -static inline bool hfi1_dbg_fault_suppress_err(struct hfi1_ibdev *ibd) -{ - return false; -} #endif #endif /* _HFI1_DEBUGFS_H */
A recent patch set to rework the usage of debugfs and to add fault injection capabilities via debugfs files to the hfi1 driver introduced a build error that only shows up when debugfs is fully disabled. The patchset mistakenly defines some empty stub functions in two different headers when debugfs is disabled. Remove the set that shouldn't have been there to resolve the issue. Fixes: a74d5307caba ("IB/hfi1: Rework fault injection machinery") Signed-off-by: Doug Ledford <dledford@redhat.com> --- drivers/infiniband/hw/hfi1/debugfs.h | 15 --------------- 1 file changed, 15 deletions(-)