| Message ID | 09bcafaab07dfde728357bfe61b6a7edfa3b25c9.camel@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [PULL,REQUEST] Please pull rdma.git | expand |
The pull request you sent on Wed, 14 Aug 2019 10:59:07 -0400:
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a8dba0531bc0ba8b65e77a4a858da4b6eeaa1b92
Thank you!
Hi Doug, Bernard, On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <dledford@redhat.com> wrote: > Fairly small pull request for -rc3. I'm out of town the rest of this > week, so I made sure to clean out as much as possible from patchworks in > enough time for 0-day to chew through it (Yay! for 0-day being back > online! :-)). Jason might send through any emergency stuff that could > pop up, otherwise I'm back next week. > > The only real thing of note is the siw ABI change. Since we just merged > siw *this* release, there are no prior kernel releases to maintain > kernel ABI with. I told Bernard that if there is anything else about > the siw ABI he thinks he might want to change before it goes set in > stone, he should get it in ASAP. The siw module was around for several > years outside the kernel tree, and it had to be revamped considerably > for inclusion upstream, so we are making no attempts to be backward > compatible with the out of tree version. Once 5.3 is actually released, > we will have our baseline ABI to maintain. [...] > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since > siw was just merged this merge window and there is no prior released > kernel to maintain compatibility with and we also updated the > rdma-core user space package to match) > Bernard Metzler (1): > RDMA/siw: Change CQ flags from 64->32 bits Obviously none of this was ever compiled for a 32-bit platform?!? Patch sent to kill the warnings. But there may be deeper issues not exposed by them. Gr{oetje,eeting}s, Geert
On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote: > Hi Doug, Bernard, > > On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <dledford@redhat.com> wrote: > > Fairly small pull request for -rc3. I'm out of town the rest of this > > week, so I made sure to clean out as much as possible from patchworks in > > enough time for 0-day to chew through it (Yay! for 0-day being back > > online! :-)). Jason might send through any emergency stuff that could > > pop up, otherwise I'm back next week. > > > > The only real thing of note is the siw ABI change. Since we just merged > > siw *this* release, there are no prior kernel releases to maintain > > kernel ABI with. I told Bernard that if there is anything else about > > the siw ABI he thinks he might want to change before it goes set in > > stone, he should get it in ASAP. The siw module was around for several > > years outside the kernel tree, and it had to be revamped considerably > > for inclusion upstream, so we are making no attempts to be backward > > compatible with the out of tree version. Once 5.3 is actually released, > > we will have our baseline ABI to maintain. > > [...] > > > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since > > siw was just merged this merge window and there is no prior released > > kernel to maintain compatibility with and we also updated the > > rdma-core user space package to match) > > > Bernard Metzler (1): > > RDMA/siw: Change CQ flags from 64->32 bits > > Obviously none of this was ever compiled for a 32-bit platform?!? It is puzzling that 0-day or anyone testing linux-next hasn't noticed this in that last 7 weeks are so.. Jason
Hi Jason, On Mon, Aug 19, 2019 at 2:14 PM Jason Gunthorpe <jgg@ziepe.ca> wrote: > On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote: > > On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <dledford@redhat.com> wrote: > > > Fairly small pull request for -rc3. I'm out of town the rest of this > > > week, so I made sure to clean out as much as possible from patchworks in > > > enough time for 0-day to chew through it (Yay! for 0-day being back > > > online! :-)). Jason might send through any emergency stuff that could > > > pop up, otherwise I'm back next week. > > > > > > The only real thing of note is the siw ABI change. Since we just merged > > > siw *this* release, there are no prior kernel releases to maintain > > > kernel ABI with. I told Bernard that if there is anything else about > > > the siw ABI he thinks he might want to change before it goes set in > > > stone, he should get it in ASAP. The siw module was around for several > > > years outside the kernel tree, and it had to be revamped considerably > > > for inclusion upstream, so we are making no attempts to be backward > > > compatible with the out of tree version. Once 5.3 is actually released, > > > we will have our baseline ABI to maintain. > > > > [...] > > > > > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since > > > siw was just merged this merge window and there is no prior released > > > kernel to maintain compatibility with and we also updated the > > > rdma-core user space package to match) > > > > > Bernard Metzler (1): > > > RDMA/siw: Change CQ flags from 64->32 bits > > > > Obviously none of this was ever compiled for a 32-bit platform?!? > > It is puzzling that 0-day or anyone testing linux-next hasn't noticed > this in that last 7 weeks are so.. Fair enough. The autobuilders have become a bit overloaded lately. Still, I would expect a commit that makes a last-minute ABI change to enable support for 32-bit platforms, to actually compile cleanly on these 32-bit platforms. To me, this looks like a big red flag... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Aug 19, 2019 at 02:29:46PM +0200, Geert Uytterhoeven wrote: > Hi Jason, > > On Mon, Aug 19, 2019 at 2:14 PM Jason Gunthorpe <jgg@ziepe.ca> wrote: > > On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <dledford@redhat.com> wrote: > > > > Fairly small pull request for -rc3. I'm out of town the rest of this > > > > week, so I made sure to clean out as much as possible from patchworks in > > > > enough time for 0-day to chew through it (Yay! for 0-day being back > > > > online! :-)). Jason might send through any emergency stuff that could > > > > pop up, otherwise I'm back next week. > > > > > > > > The only real thing of note is the siw ABI change. Since we just merged > > > > siw *this* release, there are no prior kernel releases to maintain > > > > kernel ABI with. I told Bernard that if there is anything else about > > > > the siw ABI he thinks he might want to change before it goes set in > > > > stone, he should get it in ASAP. The siw module was around for several > > > > years outside the kernel tree, and it had to be revamped considerably > > > > for inclusion upstream, so we are making no attempts to be backward > > > > compatible with the out of tree version. Once 5.3 is actually released, > > > > we will have our baseline ABI to maintain. > > > > > > [...] > > > > > > > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since > > > > siw was just merged this merge window and there is no prior released > > > > kernel to maintain compatibility with and we also updated the > > > > rdma-core user space package to match) > > > > > > > Bernard Metzler (1): > > > > RDMA/siw: Change CQ flags from 64->32 bits > > > > > > Obviously none of this was ever compiled for a 32-bit platform?!? > > > > It is puzzling that 0-day or anyone testing linux-next hasn't noticed > > this in that last 7 weeks are so.. > > Fair enough. The autobuilders have become a bit overloaded lately. > > Still, I would expect a commit that makes a last-minute ABI change to > enable support for 32-bit platforms, to actually compile cleanly on > these 32-bit platforms. > To me, this looks like a big red flag... Again, I don't know why 0-day didn't report anything. I have success logs from it saying it compiled a tree including siw on i386 allmodconfig - I don't know why you are seeing 32 bit warnings when 0-day is not reporting anything. Jason
Hi Linus, Fairly small pull request for -rc3. I'm out of town the rest of this week, so I made sure to clean out as much as possible from patchworks in enough time for 0-day to chew through it (Yay! for 0-day being back online! :-)). Jason might send through any emergency stuff that could pop up, otherwise I'm back next week. The only real thing of note is the siw ABI change. Since we just merged siw *this* release, there are no prior kernel releases to maintain kernel ABI with. I told Bernard that if there is anything else about the siw ABI he thinks he might want to change before it goes set in stone, he should get it in ASAP. The siw module was around for several years outside the kernel tree, and it had to be revamped considerably for inclusion upstream, so we are making no attempts to be backward compatible with the out of tree version. Once 5.3 is actually released, we will have our baseline ABI to maintain. Here's the boiler plate: The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus for you to fetch changes up to 2c8ccb37b08fe364f02a9914daca474d43151453: RDMA/siw: Change CQ flags from 64->32 bits (2019-08-13 12:22:06 -0400) ---------------------------------------------------------------- Pull request for 5.3-rc3 - Fix a memory registration release flow issue that was causing a WARN_ON (mlx5) - If the counters for a port aren't allocated, then we can't do operations on the non-existent counters (core) - Check the right variable for error code result (mlx5) - Fix a use after free issue (mlx5) - Fix an off by one memory leak (siw) - Actually return an error code on error (core) - Allow siw to be built on 32bit arches (siw, ABI change, but OK since siw was just merged this merge window and there is no prior released kernel to maintain compatibility with and we also updated the rdma-core user space package to match) Signed-off-by: Doug Ledford <dledford@redhat.com> ---------------------------------------------------------------- Bernard Metzler (1): RDMA/siw: Change CQ flags from 64->32 bits Dan Carpenter (3): IB/mlx5: Check the correct variable in error handling code RDMA/siw: Fix a memory leak in siw_init_cpulist() RDMA/core: Fix error code in stat_get_doit_qp() Mark Zhang (1): RDMA/counter: Prevent QP counter binding if counters unsupported Yishai Hadas (2): IB/mlx5: Fix implicit MR release flow IB/mlx5: Fix use-after-free error while accessing ev_file pointer drivers/infiniband/core/counters.c | 6 ++++++ drivers/infiniband/core/nldev.c | 8 ++++++-- drivers/infiniband/core/umem_odp.c | 4 ---- drivers/infiniband/hw/mlx5/devx.c | 11 ++++++----- drivers/infiniband/hw/mlx5/odp.c | 24 +++++++++--------------- drivers/infiniband/sw/siw/Kconfig | 2 +- drivers/infiniband/sw/siw/siw.h | 2 +- drivers/infiniband/sw/siw/siw_main.c | 4 +--- drivers/infiniband/sw/siw/siw_qp.c | 14 ++++++++++---- drivers/infiniband/sw/siw/siw_verbs.c | 16 +++++++++++----- include/uapi/rdma/siw-abi.h | 3 ++- 11 files changed, 53 insertions(+), 41 deletions(-)