Message ID | 13eb25961923f5de9eb9ecbbc94e26113d6049ef.1733815944.git.leonro@nvidia.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [rdma-rc] RDMA/nldev: Set error code in rdma_nl_notify_event | expand |
On Tue, Dec 10, 2024 at 1:03 PM Leon Romanovsky <leon@kernel.org> wrote: > > From: Chiara Meiohas <cmeiohas@nvidia.com> > > In case of error set the error code before the goto. > > Fixes: 6ff57a2ea7c2 ("RDMA/nldev: Fix NULL pointer dereferences issue in rdma_nl_notify_event") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/linux-rdma/a84a2fc3-33b6-46da-a1bd-3343fa07eaf9@stanley.mountain/ > Signed-off-by: Chiara Meiohas <cmeiohas@nvidia.com> > Reviewed-by: Maher Sanalla <msanalla@nvidia.com> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> LGTM Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index acb02f8c87c0..f13aa2661f06 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -2966,8 +2966,8 @@ int rdma_nl_notify_event(struct ib_device *device, u32 port_num, enum rdma_nl_notify_event_type type) { struct sk_buff *skb; + int ret = -EMSGSIZE; struct net *net; - int ret = 0; void *nlh; net = read_pnet(&device->coredev.rdma_net);