From patchwork Sat Dec 20 16:19:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5522791 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2AF6FBEEA8 for ; Sat, 20 Dec 2014 16:16:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4E0C620131 for ; Sat, 20 Dec 2014 16:16:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 618092014A for ; Sat, 20 Dec 2014 16:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993AbaLTQQQ (ORCPT ); Sat, 20 Dec 2014 11:16:16 -0500 Received: from mail-wg0-f43.google.com ([74.125.82.43]:49831 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbaLTQQQ (ORCPT ); Sat, 20 Dec 2014 11:16:16 -0500 Received: by mail-wg0-f43.google.com with SMTP id l18so3645164wgh.16 for ; Sat, 20 Dec 2014 08:16:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=a6UYzBm5f5QMmlXz0qbzsV4W+siJw/O97n9Sb8RpH+Y=; b=L/jknSRJRovDBnTkcscsanmbwD6sx5GldrVPIFXXsaxJBScz5ZCT9cSm+GqClWZPN0 VrKDA+RV1CcoN5ZV+WiJoqiV3byL9ovmc64edzH0t87sNxVDrCM3JQpyQAG4JWtVBrOt vWVhaLc70UHubA2Infc2Jnp0ynJMF5F3TNq3CdazPt/A9Byw8TyfT9o7OFUVstvw26wh ApaeizcbadqL5RJhbj6zdER996jZEwIRBdK5aZ5Z6bz2rsAzSWAqb4TB0BbWCXvE9tx7 l/ogMGKKVyEvamUmcWUNpg3poe2mwODIfnfNrq3z8ifbAh76VPL6vR9jPfy+yvH8eGYS R5KQ== X-Gm-Message-State: ALoCoQmRyyI3MT48rn43mljzHGmJIMoLZ2hA6BYXdHAA7YXd+cIQrDKnSVRID/iIcg0bwL1Teegk X-Received: by 10.194.222.98 with SMTP id ql2mr25749983wjc.36.1419092175056; Sat, 20 Dec 2014 08:16:15 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id vm8sm16804161wjc.6.2014.12.20.08.16.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 08:16:14 -0800 (PST) From: Rickard Strandqvist To: Mike Marciniszyn , Roland Dreier Cc: Rickard Strandqvist , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused function Date: Sat, 20 Dec 2014 17:19:02 +0100 Message-Id: <1419092342-7120-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the function ipath_unordered_wc() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist Acked-by: Mike Marciniszyn --- drivers/infiniband/hw/ipath/ipath_kernel.h | 3 --- drivers/infiniband/hw/ipath/ipath_wc_ppc64.c | 13 ------------- drivers/infiniband/hw/ipath/ipath_wc_x86_64.c | 15 --------------- 3 files changed, 31 deletions(-) diff --git a/drivers/infiniband/hw/ipath/ipath_kernel.h b/drivers/infiniband/hw/ipath/ipath_kernel.h index 6559af6..e08db70 100644 --- a/drivers/infiniband/hw/ipath/ipath_kernel.h +++ b/drivers/infiniband/hw/ipath/ipath_kernel.h @@ -908,9 +908,6 @@ void ipath_chip_cleanup(struct ipath_devdata *); /* clean up any chip type-specific stuff */ void ipath_chip_done(void); -/* check to see if we have to force ordering for write combining */ -int ipath_unordered_wc(void); - void ipath_disarm_piobufs(struct ipath_devdata *, unsigned first, unsigned cnt); void ipath_cancel_sends(struct ipath_devdata *, int); diff --git a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c index 1d7bd82..1a7e20a 100644 --- a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c +++ b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c @@ -47,16 +47,3 @@ int ipath_enable_wc(struct ipath_devdata *dd) { return 0; } - -/** - * ipath_unordered_wc - indicate whether write combining is unordered - * - * Because our performance depends on our ability to do write - * combining mmio writes in the most efficient way, we need to - * know if we are on a processor that may reorder stores when - * write combining. - */ -int ipath_unordered_wc(void) -{ - return 1; -} diff --git a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c index 3428acb..4ad0b93 100644 --- a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c +++ b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c @@ -167,18 +167,3 @@ void ipath_disable_wc(struct ipath_devdata *dd) dd->ipath_wc_cookie = 0; /* even on failure */ } } - -/** - * ipath_unordered_wc - indicate whether write combining is ordered - * - * Because our performance depends on our ability to do write combining mmio - * writes in the most efficient way, we need to know if we are on an Intel - * or AMD x86_64 processor. AMD x86_64 processors flush WC buffers out in - * the order completed, and so no special flushing is required to get - * correct ordering. Intel processors, however, will flush write buffers - * out in "random" orders, and so explicit ordering is needed at times. - */ -int ipath_unordered_wc(void) -{ - return boot_cpu_data.x86_vendor != X86_VENDOR_AMD; -}