| Message ID | 1432220202-9834-11-git-send-email-ogerlitz@mellanox.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, 2015-05-21 at 17:56 +0300, Or Gerlitz wrote: > From: Matan Barak <matanb@mellanox.com> > > mlx4 needs to report the number of supported timestamp > bits (mask) and the hca_core_clock frequency. > > Signed-off-by: Matan Barak <matanb@mellanox.com> > Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> > --- > drivers/infiniband/hw/mlx4/main.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c > index ef211c8..a5a90c4 100644 > --- a/drivers/infiniband/hw/mlx4/main.c > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -233,6 +233,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, > props->max_total_mcast_qp_attach = props->max_mcast_qp_attach * > props->max_mcast_grp; > props->max_map_per_fmr = dev->dev->caps.max_fmr_maps; > + props->hca_core_clock = dev->dev->caps.hca_core_clock; > + props->timestamp_mask = 0xFFFFFFFFFFFFULL; > > out: > kfree(in_mad); Or, please squash 8, 9, and 10 to a single patch. They all are "add support for timestamping to mlx4" but without squashing them together, the support they add is broken/partial.
On Fri, May 29, 2015 at 7:41 PM, Doug Ledford <dledford@redhat.com> wrote: > On Thu, 2015-05-21 at 17:56 +0300, Or Gerlitz wrote: >> From: Matan Barak <matanb@mellanox.com> >> >> mlx4 needs to report the number of supported timestamp >> bits (mask) and the hca_core_clock frequency. >> >> Signed-off-by: Matan Barak <matanb@mellanox.com> >> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com> >> --- >> drivers/infiniband/hw/mlx4/main.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c >> index ef211c8..a5a90c4 100644 >> --- a/drivers/infiniband/hw/mlx4/main.c >> +++ b/drivers/infiniband/hw/mlx4/main.c >> @@ -233,6 +233,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, >> props->max_total_mcast_qp_attach = props->max_mcast_qp_attach * >> props->max_mcast_grp; >> props->max_map_per_fmr = dev->dev->caps.max_fmr_maps; >> + props->hca_core_clock = dev->dev->caps.hca_core_clock; >> + props->timestamp_mask = 0xFFFFFFFFFFFFULL; >> >> out: >> kfree(in_mad); > > Or, please squash 8, 9, and 10 to a single patch. They all are "add > support for timestamping to mlx4" but without squashing them together, > the support they add is broken/partial. Sure, will do. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index ef211c8..a5a90c4 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -233,6 +233,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, props->max_total_mcast_qp_attach = props->max_mcast_qp_attach * props->max_mcast_grp; props->max_map_per_fmr = dev->dev->caps.max_fmr_maps; + props->hca_core_clock = dev->dev->caps.hca_core_clock; + props->timestamp_mask = 0xFFFFFFFFFFFFULL; out: kfree(in_mad);