diff mbox

[librdmacm] fix udpong segfault on rconnect error

Message ID 1466601350-47463-1-git-send-email-jarod@redhat.com (mailing list archive)
State Accepted
Headers show

Commit Message

Jarod Wilson June 22, 2016, 1:15 p.m. UTC
Before patch:
[root@rdma-qe-05 librdmacm (master *)]$ udpong -s 172.31.45.4
name      bytes   xfers   total       time     Gb/sec    usec/xfer
rconnect: No such file or directory
Segmentation fault (core dumped)

After patch:
[root@rdma-qe-05 librdmacm (master *)]$ ./examples/udpong -s 172.31.45.4
name      bytes   xfers   total       time     Gb/sec    usec/xfer
rconnect: No such file or directory

Simple fix, just a missing goto on error, so we don't try to do things
that are already expected to fail.

CC: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 examples/udpong.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Hefty, Sean June 23, 2016, 4:08 p.m. UTC | #1
Thanks - applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/examples/udpong.c b/examples/udpong.c
index 97713a2..6affc62 100644
--- a/examples/udpong.c
+++ b/examples/udpong.c
@@ -427,6 +427,7 @@  static int client_connect(void)
 	if (ret) {
 		perror("rconnect");
 		rs_close(rs);
+		goto out;
 	}
 
 	msg.op = msg_op_login;