| Message ID | 1467549727-23479-2-git-send-email-leon@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Jul 3, 2016 at 3:42 PM, Leon Romanovsky <leon@kernel.org> wrote: > From: Talat Batheesh <talatb@mellanox.com> > > In order to configure QoS for Raw Packet QP, the user passes the SL > in the AV attribute when modifying the QP from INIT to RTR state. > > This SL is used later on to set the Ethernet Priority of the QP. > > Until today, we couldn't pass the AV attribute for Raw Packet QP > because it was blocked in the QP state transition matrix. This > patch adds the AV as optional in INIT to RTR. > > Fixes: 8a51866f0810 ('IB: Add ib_modify_qp_is_ok() library function') This commit is 10y old and was done way before RAW Packet QP was added to the kernel, please fix your Fixes: line... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 04, 2016 at 12:51:00AM +0300, Or Gerlitz wrote: > On Sun, Jul 3, 2016 at 3:42 PM, Leon Romanovsky <leon@kernel.org> wrote: > > From: Talat Batheesh <talatb@mellanox.com> > > > > In order to configure QoS for Raw Packet QP, the user passes the SL > > in the AV attribute when modifying the QP from INIT to RTR state. > > > > This SL is used later on to set the Ethernet Priority of the QP. > > > > Until today, we couldn't pass the AV attribute for Raw Packet QP > > because it was blocked in the QP state transition matrix. This > > patch adds the AV as optional in INIT to RTR. > > > > Fixes: 8a51866f0810 ('IB: Add ib_modify_qp_is_ok() library function') > > This commit is 10y old and was done way before RAW Packet QP was added > to the kernel, please fix your Fixes: line... It isn't a fixes if you are adding a new feature. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 04, 2016 at 09:33:37AM -0600, Jason Gunthorpe wrote: > On Mon, Jul 04, 2016 at 12:51:00AM +0300, Or Gerlitz wrote: > > On Sun, Jul 3, 2016 at 3:42 PM, Leon Romanovsky <leon@kernel.org> wrote: > > > From: Talat Batheesh <talatb@mellanox.com> > > > > > > In order to configure QoS for Raw Packet QP, the user passes the SL > > > in the AV attribute when modifying the QP from INIT to RTR state. > > > > > > This SL is used later on to set the Ethernet Priority of the QP. > > > > > > Until today, we couldn't pass the AV attribute for Raw Packet QP > > > because it was blocked in the QP state transition matrix. This > > > patch adds the AV as optional in INIT to RTR. > > > > > > Fixes: 8a51866f0810 ('IB: Add ib_modify_qp_is_ok() library function') > > > > This commit is 10y old and was done way before RAW Packet QP was added > > to the kernel, please fix your Fixes: line... > > It isn't a fixes if you are adding a new feature. You are right, I'll resubmit. > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index 2e813ed..ba75780 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -932,6 +932,7 @@ static const struct { IB_QP_QKEY), [IB_QPT_GSI] = (IB_QP_PKEY_INDEX | IB_QP_QKEY), + [IB_QPT_RAW_PACKET] = IB_QP_AV, }, }, },