diff mbox

[V2] Use smaller 512 byte messages for portmapper messages

Message ID 1468869709-66592-1-git-send-email-shiraz.saleem@intel.com (mailing list archive)
State Accepted
Headers show

Commit Message

Shiraz Saleem July 18, 2016, 7:21 p.m. UTC 
From: Mustafa Ismail <mustafa.ismail@intel.com>

Portmapper messages are short and do not occupy more than 512 bytes.
Lower portmapper message size to 512 bytes. This change significantly
reduces the amount of memory needed when trying to establish a large
number of connections simultaneously. The old value is based on page
size. 

Signed-off-by: Faisal Latif <faisal.latif@intel.com>
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
---

V2: update commit message with justification for lowered message size and
its old value.
 
 drivers/infiniband/core/iwpm_util.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Leon Romanovsky July 19, 2016, 5:35 a.m. UTC | #1 
On Mon, Jul 18, 2016 at 02:21:49PM -0500, Shiraz Saleem wrote:
> From: Mustafa Ismail <mustafa.ismail@intel.com>
> 
> Portmapper messages are short and do not occupy more than 512 bytes.
> Lower portmapper message size to 512 bytes. This change significantly
> reduces the amount of memory needed when trying to establish a large
> number of connections simultaneously. The old value is based on page
> size. 

The old value was minimal between PAGE_SIZE and 8K.

Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Doug Ledford Aug. 2, 2016, 7:12 p.m. UTC | #2 
On Mon, 2016-07-18 at 14:21 -0500, Shiraz Saleem wrote:
> From: Mustafa Ismail <mustafa.ismail@intel.com>
> 
> Portmapper messages are short and do not occupy more than 512 bytes.
> Lower portmapper message size to 512 bytes. This change significantly
> reduces the amount of memory needed when trying to establish a large
> number of connections simultaneously. The old value is based on page
> size. 
> 
> Signed-off-by: Faisal Latif <faisal.latif@intel.com>
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> 
> V2: update commit message with justification for lowered message size
> and
> its old value.
> 

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c
index b65e06c..ade71e7 100644
--- a/drivers/infiniband/core/iwpm_util.c
+++ b/drivers/infiniband/core/iwpm_util.c
@@ -37,6 +37,7 @@ 
 #define IWPM_MAPINFO_HASH_MASK	(IWPM_MAPINFO_HASH_SIZE - 1)
 #define IWPM_REMINFO_HASH_SIZE	64
 #define IWPM_REMINFO_HASH_MASK	(IWPM_REMINFO_HASH_SIZE - 1)
+#define IWPM_MSG_SIZE		512
 
 static LIST_HEAD(iwpm_nlmsg_req_list);
 static DEFINE_SPINLOCK(iwpm_nlmsg_req_lock);
@@ -452,7 +453,7 @@  struct sk_buff *iwpm_create_nlmsg(u32 nl_op, struct nlmsghdr **nlh,
 {
 	struct sk_buff *skb = NULL;
 
-	skb = dev_alloc_skb(NLMSG_GOODSIZE);
+	skb = dev_alloc_skb(IWPM_MSG_SIZE);
 	if (!skb) {
 		pr_err("%s Unable to allocate skb\n", __func__);
 		goto create_nlmsg_exit;