From patchwork Wed Jul 27 19:17:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarod Wilson X-Patchwork-Id: 9250351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 653C06077C for ; Wed, 27 Jul 2016 19:18:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 561D32624C for ; Wed, 27 Jul 2016 19:18:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AFE626538; Wed, 27 Jul 2016 19:18:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B68626253 for ; Wed, 27 Jul 2016 19:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758374AbcG0TRu (ORCPT ); Wed, 27 Jul 2016 15:17:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46058 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758339AbcG0TRn (ORCPT ); Wed, 27 Jul 2016 15:17:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9A804E020; Wed, 27 Jul 2016 19:17:42 +0000 (UTC) Received: from hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com (hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com [10.16.184.47]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6RJHens032006; Wed, 27 Jul 2016 15:17:42 -0400 From: Jarod Wilson To: linux-rdma@vger.kernel.org Cc: Jarod Wilson , Yishai Hadas Subject: [PATCH libmlx5 3/6] fix buffer overrun copying inline header Date: Wed, 27 Jul 2016 15:17:24 -0400 Message-Id: <1469647047-7544-4-git-send-email-jarod@redhat.com> In-Reply-To: <1469647047-7544-1-git-send-email-jarod@redhat.com> References: <1469647047-7544-1-git-send-email-jarod@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 27 Jul 2016 19:17:42 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP At present, the size of eseg->inline_hdr_start is 16 bits, while MLX5_ETH_L2_INLINE_HEADER_SIZE is 18, so there are attempts made to copy 18 bits into 16 bits of storage. The mlx5_dbg() statement in copy_eth_inline_header() suggests that perhaps MLX5_ETH_L2_INLINE_HEADER_SIZE should be only 16, not 18. So either that needs to be changed, or the inline_hdr_start array needs to be bumped up to 3 bytes instead of 2. CC: Yishai Hadas Signed-off-by: Jarod Wilson --- src/wqe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wqe.h b/src/wqe.h index c2622d5..c0e176d 100644 --- a/src/wqe.h +++ b/src/wqe.h @@ -77,7 +77,7 @@ struct mlx5_eqe_qp_srq { }; enum { - MLX5_ETH_L2_INLINE_HEADER_SIZE = 18, + MLX5_ETH_L2_INLINE_HEADER_SIZE = 16, }; enum {