From patchwork Thu Aug 18 17:32:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarod Wilson X-Patchwork-Id: 9289117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 711A1607FF for ; Fri, 19 Aug 2016 01:54:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61D672915B for ; Fri, 19 Aug 2016 01:54:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 56CCB29161; Fri, 19 Aug 2016 01:54:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D55292915B for ; Fri, 19 Aug 2016 01:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbcHSByI (ORCPT ); Thu, 18 Aug 2016 21:54:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754263AbcHSBsg (ORCPT ); Thu, 18 Aug 2016 21:48:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C7D93F722; Thu, 18 Aug 2016 17:32:41 +0000 (UTC) Received: from hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com (hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com [10.16.184.47]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7IHWUAL018884; Thu, 18 Aug 2016 13:32:40 -0400 From: Jarod Wilson To: linux-rdma@vger.kernel.org Cc: Jarod Wilson , Gil Rockah Subject: [PATCH perftest 19/23] perftest_resources: make sure num_of_qps is never 0 Date: Thu, 18 Aug 2016 13:32:14 -0400 Message-Id: <1471541538-20270-20-git-send-email-jarod@redhat.com> In-Reply-To: <1471541538-20270-1-git-send-email-jarod@redhat.com> References: <1471541538-20270-1-git-send-email-jarod@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 18 Aug 2016 17:32:41 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Somehow or another, if someone were to feed a 1 into num_of_qps, then we'd have num_of_qps = 1 / 2 = 0, and later on, portindex % 0 -- a divide by zero condition. Make sure that can't happen. This resolves a coverity/clang warning. CC: Gil Rockah Signed-off-by: Jarod Wilson --- src/perftest_resources.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/perftest_resources.c b/src/perftest_resources.c index 7e982e9..959a5df 100755 --- a/src/perftest_resources.c +++ b/src/perftest_resources.c @@ -1830,6 +1830,8 @@ int ctx_modify_dc_qp_to_init(struct ibv_qp *qp,struct perftest_parameters *user_ if (user_param->duplex || user_param->tst == LAT) { num_of_qps /= 2; + if (num_of_qps < 2) + num_of_qps = 2; num_of_qps_per_port = num_of_qps / 2; } @@ -1896,6 +1898,8 @@ int ctx_modify_qp_to_init(struct ibv_qp *qp,struct perftest_parameters *user_par if ( user_param->use_xrc && (user_param->duplex || user_param->tst == LAT)) { num_of_qps /= 2; + if (num_of_qps < 2) + num_of_qps = 2; num_of_qps_per_port = num_of_qps / 2; }