| Message ID | 1487322982-29215-1-git-send-email-yanjun.zhu@oracle.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 2/17/2017 1:16 AM, Zhu Yanjun wrote: > In the function rds_ib_xmit_atomic, ib_ring is not allocated > successfully. As such, it is not necessary to unalloc it. > > Cc: Joe Jin <joe.jin@oracle.com> > Cc: Junxiao Bi <junxiao.bi@oracle.com> > Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> > --- > Change from v1 to v2: > fix the word errors in the short log. > Looks fine. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Zhu Yanjun <yanjun.zhu@oracle.com> Date: Fri, 17 Feb 2017 04:16:22 -0500 > In the function rds_ib_xmit_atomic, ib_ring is not allocated > successfully. As such, it is not necessary to unalloc it. > > Cc: Joe Jin <joe.jin@oracle.com> > Cc: Junxiao Bi <junxiao.bi@oracle.com> > Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> > --- > Change from v1 to v2: > fix the word errors in the short log. Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c index 84d90c9..84b34cc 100644 --- a/net/rds/ib_send.c +++ b/net/rds/ib_send.c @@ -765,7 +765,6 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op) work_alloc = rds_ib_ring_alloc(&ic->i_send_ring, 1, &pos); if (work_alloc != 1) { - rds_ib_ring_unalloc(&ic->i_send_ring, work_alloc); rds_ib_stats_inc(s_ib_tx_ring_full); ret = -ENOMEM; goto out;
In the function rds_ib_xmit_atomic, ib_ring is not allocated successfully. As such, it is not necessary to unalloc it. Cc: Joe Jin <joe.jin@oracle.com> Cc: Junxiao Bi <junxiao.bi@oracle.com> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> --- Change from v1 to v2: fix the word errors in the short log. net/rds/ib_send.c | 1 - 1 file changed, 1 deletion(-)