| Message ID | 1488314857-28327-9-git-send-email-nicolas.dichtel@6wind.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Feb 28, 2017 at 09:47:34PM +0100, Nicolas Dichtel wrote: > This patch prepares the uapi export by fixing the following error: > > .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) > char cru_name[CRYPTO_MAX_ALG_NAME]; > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > include/linux/crypto.h | 2 +- > include/uapi/linux/cryptouser.h | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index c0b0cf3d2d2f..4cf29a35bb4b 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -24,6 +24,7 @@ > #include <linux/slab.h> > #include <linux/string.h> > #include <linux/uaccess.h> > +#include <uapi/linux/cryptouser.h> Nack. cryptouser is just one interface in the crypto API. It should not be included by every single crypto user in the kernel. You could perhaps introduce a new file under uapi just for this. Cheers,
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi directories.
The patch #5 was spotted by code review: there is no in-tree user of this
functionality.
Patch #6 fixes some warnings/errors reported by 0-day tests.
Patch #7 to #9 fix some errors when the corresponding files are included by
userland.
Patches #10 and #11 remove the need to list explicitly headers. Now all files
under an uapi directory are exported.
This series has been tested with a 'make headers_install' on x86 and a
'make headers_install_all'. I've checked the result of both commands.
This patch is built against linus tree. If I must rebase it against the kbuild
tree, just tell me.
Michal, is this series going through your tree?
v8 -> v9:
- rebase on top of linus tree
- patch #8: add include/uapi/linux/crypto.h
v7 -> v8:
- rebase on top of linus tree
- add patch #7, #8 and #9
v6 -> v7:
- rebase on top of linus tree
- patch #7: remove autogenerated files from the list in the commit log
v5 -> v6:
- patch #6: remove change of include/uapi/linux/media.h
- patch #7: fix hdr export when 'make O=' is used (look for genhdr files in
the right directory)
- patch #8: fix 'make headers_check'
v4 -> v5:
- patch #3: get back to v3 (don't export msr-index.h)
- patch #6: new in this version
- patch #7: fix compilation by introducing header-n
v3 -> v4:
- first patch has been included
- patch #4: get back to v2 and remove arch/x86/include/asm/msr-index.h
v2 -> v3:
- patch #1: remove arch/arm/include/asm/types.h
- patch #2: remove arch/h8300/include/asm/bitsperlong.h
- patch #3: remove arch/nios2/include/uapi/asm/setup.h
- patch #4: don't export msr-index.h
- patch #5: fix a typo: s/unput-files3-name/input-files3-name
- patch #6: no change
- patch #7: fix include/uapi/asm-generic/Kbuild.asm by introducing mandatory-y
- add patch #8
v1 -> v2:
- add patch #1 to #6
- patch #7: remove use of header-y
Comments are welcomed,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 02/03/2017 à 17:56, Nicolas Dichtel a écrit : > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported headers are under an uapi directory: > path #4 stops searching files in non uapi directories. > The patch #5 was spotted by code review: there is no in-tree user of this > functionality. > Patch #6 fixes some warnings/errors reported by 0-day tests. > Patch #7 to #9 fix some errors when the corresponding files are included by > userland. > Patches #10 and #11 remove the need to list explicitly headers. Now all files > under an uapi directory are exported. > > This series has been tested with a 'make headers_install' on x86 and a > 'make headers_install_all'. I've checked the result of both commands. > > This patch is built against linus tree. If I must rebase it against the kbuild > tree, just tell me. > Michal, is this series going through your tree? I'm a bit pushy on this, but it would be nice to get this series in before the rc1. In fact, it would certainly be better to have this living some times in -next, but it would probably generate a lot of conflicts in linux-next. OTOH those conflicts would be easy to solve. Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 02/03/2017 à 17:56, Nicolas Dichtel a écrit : > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported headers are under an uapi directory: > path #4 stops searching files in non uapi directories. > The patch #5 was spotted by code review: there is no in-tree user of this > functionality. > Patch #6 fixes some warnings/errors reported by 0-day tests. > Patch #7 to #9 fix some errors when the corresponding files are included by > userland. > Patches #10 and #11 remove the need to list explicitly headers. Now all files > under an uapi directory are exported. > > This series has been tested with a 'make headers_install' on x86 and a > 'make headers_install_all'. I've checked the result of both commands. > > This patch is built against linus tree. If I must rebase it against the kbuild > tree, just tell me. > Michal, is this series going through your tree? Still waiting to know who may take this series in its tree ;-) kbuild tree has not been updated since two months (4.10-rc1) :/ Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nicolas, 2017-03-11 1:34 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > Le 02/03/2017 à 17:56, Nicolas Dichtel a écrit : >> Patches #1 and #2 are just cleanup: some exported headers were still under >> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was >> not under an uapi directory. >> After these three patches, all exported headers are under an uapi directory: >> path #4 stops searching files in non uapi directories. >> The patch #5 was spotted by code review: there is no in-tree user of this >> functionality. >> Patch #6 fixes some warnings/errors reported by 0-day tests. >> Patch #7 to #9 fix some errors when the corresponding files are included by >> userland. >> Patches #10 and #11 remove the need to list explicitly headers. Now all files >> under an uapi directory are exported. >> >> This series has been tested with a 'make headers_install' on x86 and a >> 'make headers_install_all'. I've checked the result of both commands. >> >> This patch is built against linus tree. If I must rebase it against the kbuild >> tree, just tell me. >> Michal, is this series going through your tree? > Still waiting to know who may take this series in its tree ;-) I will take care of this. > kbuild tree has not been updated since two months (4.10-rc1) :/ Michal's tree is not active these days. Going forward, I will queue up Kbuild patches in my repository. BTW, this series does not apply cleanly. If you could rebase it onto v4.11-rc1 tag, it would be helpful. Thanks!
Le 11/03/2017 à 06:43, Masahiro Yamada a écrit : [snip] > > I will take care of this. Thank you. > > > >> kbuild tree has not been updated since two months (4.10-rc1) :/ > > Michal's tree is not active these days. Ok, I didn't know that. > Going forward, I will queue up Kbuild patches in my repository. > > > > BTW, this series does not apply cleanly. > > If you could rebase it onto v4.11-rc1 tag, > it would be helpful. You really want this on top of 4.11-rc1 or the last linus tag, ie v4.11-rc2? Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ni Nicolas, 2017-03-14 1:57 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: >> BTW, this series does not apply cleanly. >> >> If you could rebase it onto v4.11-rc1 tag, >> it would be helpful. > You really want this on top of 4.11-rc1 or the last linus tag, ie v4.11-rc2? > Basically, I queue up patches based on -rc1 tag unless there is a particular reason for otherwise. If it is based on -rc1, will it cause conflicts with Linus tree?
Le 14/03/2017 à 06:38, Masahiro Yamada a écrit : > Ni Nicolas, > > > 2017-03-14 1:57 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: >>> BTW, this series does not apply cleanly. >>> >>> If you could rebase it onto v4.11-rc1 tag, >>> it would be helpful. >> You really want this on top of 4.11-rc1 or the last linus tag, ie v4.11-rc2? >> > > Basically, I queue up patches based on -rc1 tag > unless there is a particular reason for otherwise. Ok, thank you for the explanation. > > If it is based on -rc1, will it cause conflicts with Linus tree? I will check and let you know in the v10 submission. Thank you, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi directories.
The patch #5 was spotted by code review: there is no in-tree user of this
functionality.
Patch #6 fixes some warnings/errors reported by 0-day tests.
Patch #7 to #9 fix some errors when the corresponding files are included by
userland.
Patches #10 and #11 remove the need to list explicitly headers. Now all files
under an uapi directory are exported.
This series has been tested with a 'make headers_install' on x86 and a
'make headers_install_all'. I've checked the result of both commands.
This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1).
I didn't find any conflict with v4.11-rc2.
v9 -> v10:
- rebase on top of masahiroy/linux-kbuild.git#for-next
- patch #4 & #10: fix dependency check
- fix some typos in commits logs
v8 -> v9:
- rebase on top of linus tree
- patch #8: add include/uapi/linux/crypto.h
v7 -> v8:
- rebase on top of linus tree
- add patch #7, #8 and #9
v6 -> v7:
- rebase on top of linus tree
- patch #7: remove autogenerated files from the list in the commit log
v5 -> v6:
- patch #6: remove change of include/uapi/linux/media.h
- patch #7: fix hdr export when 'make O=' is used (look for genhdr files in
the right directory)
- patch #8: fix 'make headers_check'
v4 -> v5:
- patch #3: get back to v3 (don't export msr-index.h)
- patch #6: new in this version
- patch #7: fix compilation by introducing header-n
v3 -> v4:
- first patch has been included
- patch #4: get back to v2 and remove arch/x86/include/asm/msr-index.h
v2 -> v3:
- patch #1: remove arch/arm/include/asm/types.h
- patch #2: remove arch/h8300/include/asm/bitsperlong.h
- patch #3: remove arch/nios2/include/uapi/asm/setup.h
- patch #4: don't export msr-index.h
- patch #5: fix a typo: s/unput-files3-name/input-files3-name
- patch #6: no change
- patch #7: fix include/uapi/asm-generic/Kbuild.asm by introducing mandatory-y
- add patch #8
v1 -> v2:
- add patch #1 to #6
- patch #7: remove use of header-y
Comments are welcomed,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported headers are under an uapi directory: > path #4 stops searching files in non uapi directories. > The patch #5 was spotted by code review: there is no in-tree user of this > functionality. > Patch #6 fixes some warnings/errors reported by 0-day tests. > Patch #7 to #9 fix some errors when the corresponding files are included by > userland. > Patches #10 and #11 remove the need to list explicitly headers. Now all files > under an uapi directory are exported. > > This series has been tested with a 'make headers_install' on x86 and a > 'make headers_install_all'. I've checked the result of both commands. > > This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1). > I didn't find any conflict with v4.11-rc2. Masahiro, is this series under review or do you expect something else on my side? Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nicolas, 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : >> Patches #1 and #2 are just cleanup: some exported headers were still under >> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was >> not under an uapi directory. >> After these three patches, all exported headers are under an uapi directory: >> path #4 stops searching files in non uapi directories. >> The patch #5 was spotted by code review: there is no in-tree user of this >> functionality. >> Patch #6 fixes some warnings/errors reported by 0-day tests. >> Patch #7 to #9 fix some errors when the corresponding files are included by >> userland. >> Patches #10 and #11 remove the need to list explicitly headers. Now all files >> under an uapi directory are exported. >> >> This series has been tested with a 'make headers_install' on x86 and a >> 'make headers_install_all'. I've checked the result of both commands. >> >> This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1). >> I didn't find any conflict with v4.11-rc2. > Masahiro, is this series under review or do you expect something else on my side? > Under review. Please give me time to take a closer look. Sorry for the delay.
Le 24/03/2017 à 09:42, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: >> Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : >>> Patches #1 and #2 are just cleanup: some exported headers were still under >>> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was >>> not under an uapi directory. >>> After these three patches, all exported headers are under an uapi directory: >>> path #4 stops searching files in non uapi directories. >>> The patch #5 was spotted by code review: there is no in-tree user of this >>> functionality. >>> Patch #6 fixes some warnings/errors reported by 0-day tests. >>> Patch #7 to #9 fix some errors when the corresponding files are included by >>> userland. >>> Patches #10 and #11 remove the need to list explicitly headers. Now all files >>> under an uapi directory are exported. >>> >>> This series has been tested with a 'make headers_install' on x86 and a >>> 'make headers_install_all'. I've checked the result of both commands. >>> >>> This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1). >>> I didn't find any conflict with v4.11-rc2. >> Masahiro, is this series under review or do you expect something else on my side? >> > > Under review. > Please give me time to take a closer look. > Sorry for the delay. No problem, take your time. I just wanted to be sure to not miss something ;-) Thank you, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nocolas, 2017-03-24 18:03 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > Le 24/03/2017 à 09:42, Masahiro Yamada a écrit : >> Hi Nicolas, >> >> >> 2017-03-24 17:32 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: >>> Le 14/03/2017 à 13:54, Nicolas Dichtel a écrit : >>>> Patches #1 and #2 are just cleanup: some exported headers were still under >>>> a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was >>>> not under an uapi directory. >>>> After these three patches, all exported headers are under an uapi directory: >>>> path #4 stops searching files in non uapi directories. >>>> The patch #5 was spotted by code review: there is no in-tree user of this >>>> functionality. >>>> Patch #6 fixes some warnings/errors reported by 0-day tests. >>>> Patch #7 to #9 fix some errors when the corresponding files are included by >>>> userland. >>>> Patches #10 and #11 remove the need to list explicitly headers. Now all files >>>> under an uapi directory are exported. >>>> >>>> This series has been tested with a 'make headers_install' on x86 and a >>>> 'make headers_install_all'. I've checked the result of both commands. >>>> >>>> This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1). >>>> I didn't find any conflict with v4.11-rc2. >>> Masahiro, is this series under review or do you expect something else on my side? >>> >> >> Under review. >> Please give me time to take a closer look. >> Sorry for the delay. > No problem, take your time. I just wanted to be sure to not miss something ;-) > > As a whole, this series is amazing. Thanks for your great work! I added some comments, but they are trivial. I wanted to leave comments/questions on 10/11, but I could not find 10/11 in my mailbox. I do not know why. I am leaving comments on the cover-letter, the following are related to 10/11. [1] >mandatory-y += $(foreach hdr,$(opt-header), \ > $(if \ > $(wildcard \ > $(srctree)/arch/$(SRCARCH)/include/uapi/asm/$(hdr) \ > $(srctree)/arch/$(SRCARCH)/include/asm/$(hdr) \ > ), \ > $(hdr) \ > )) What is this actually checking? If ARCH has its own (uapi/)asm/{kvm.h,kvm_para.h,a.out.h}, they are added to mandatory-y, then they are checked if they exist. But, we know they exist. This check reminds us only when we added asm/*.h but forgot to add uapi/asm/*.h $(srctree)/arch/$(SRCARCH)/include/uapi/asm/$(hdr) seems unneeded at least. (perhaps, the whole hunk might be unneeded.) [2] >ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/a.out.h \ > $(srctree)/arch/$(SRCARCH)/include/asm/a.out.h),) >header-n += a.out.h >endif > >ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/kvm.h \ > $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h),) >header-n += kvm.h >endif > >ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/kvm_para.h \ > $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h),) >header-n += kvm_para.h >endif This series intends all headers are exported from uapi/, correct? Do we still need to check $(srctree)/arch/$(SRCARCH)/include/asm/*.h ? (related to [1]) [3] >--- 7.1 header-n > >header-n is essentially used by include/uapi/linux/Kbuild to avoid >exporting specific headers (e.g. kvm.h) on architectures that do not >support it. It should be avoided as much as possible. Going forward, header-y will be never used because uapi/ is exported by default. So, I wonder if we could rename this into something clearer. Kbuild supports "no-clean-files". (Please see ./Kbuild for its usage) I guess this notation seems clearer when we want to negate the default behavior. Can you consider "no-export", "no-export-files", "no-export-headers" or whatever you like? Thanks!
Hi Masahiro, Le 27/03/2017 à 07:26, Masahiro Yamada a écrit : > Hi Nocolas, > > > 2017-03-24 18:03 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: [snip] > > > As a whole, this series is amazing. Thanks for your great work! Thank you. And thank you for taking time to review it. > > > I added some comments, but they are trivial. > > > > > I wanted to leave comments/questions on 10/11, > but I could not find 10/11 in my mailbox. I do not know why. Note that you can download the mail from the kbuild patchwork, open it with your email client and do a reply ;-) > > > I am leaving comments on the cover-letter, > the following are related to 10/11. > > > > [1] > >> mandatory-y += $(foreach hdr,$(opt-header), \ >> $(if \ >> $(wildcard \ >> $(srctree)/arch/$(SRCARCH)/include/uapi/asm/$(hdr) \ >> $(srctree)/arch/$(SRCARCH)/include/asm/$(hdr) \ >> ), \ >> $(hdr) \ >> )) > > What is this actually checking? > > If ARCH has its own (uapi/)asm/{kvm.h,kvm_para.h,a.out.h}, > they are added to mandatory-y, then they are checked if they exist. > But, we know they exist. Yes, you're right. With english words : 'those files are mandatory only if they exist', thus they are not mandatory at all :) > > > This check reminds us only when we added asm/*.h > but forgot to add uapi/asm/*.h > > $(srctree)/arch/$(SRCARCH)/include/uapi/asm/$(hdr) seems unneeded at least. > (perhaps, the whole hunk might be unneeded.) I think we can remove the whole hunk (see also [2]). > > > > [2] > >> ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/a.out.h \ >> $(srctree)/arch/$(SRCARCH)/include/asm/a.out.h),) >> header-n += a.out.h >> endif >> >> ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/kvm.h \ >> $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h),) >> header-n += kvm.h >> endif >> >> ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/uapi/asm/kvm_para.h \ >> $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h),) >> header-n += kvm_para.h >> endif > > This series intends all headers are exported from uapi/, correct? > Do we still need to check $(srctree)/arch/$(SRCARCH)/include/asm/*.h ? > (related to [1]) No you're right, uapi/asm/*.h is enough. Those files should be exported only if the uapi/asm/ counterpart exists. > > > > [3] > >> --- 7.1 header-n >> >> header-n is essentially used by include/uapi/linux/Kbuild to avoid >> exporting specific headers (e.g. kvm.h) on architectures that do not >> support it. It should be avoided as much as possible. > > > Going forward, header-y will be never used > because uapi/ is exported by default. > > So, I wonder if we could rename this into something clearer. > > Kbuild supports "no-clean-files". > (Please see ./Kbuild for its usage) > I guess this notation seems clearer > when we want to negate the default behavior. > > Can you consider "no-export", "no-export-files", "no-export-headers" > or whatever you like? No problem, let's use no-export-headers. Thank you, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patches #1 and #2 are just cleanup: some exported headers were still under
a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was
not under an uapi directory.
After these three patches, all exported headers are under an uapi directory:
path #4 stops searching files in non uapi directories.
The patch #5 was spotted by code review: there is no in-tree user of this
functionality.
Patch #6 fixes some warnings/errors reported by 0-day tests.
Patch #7 to #9 fix some errors when the corresponding files are included by
userland.
Patches #10 and #11 remove the need to list explicitly headers. Now all files
under an uapi directory are exported.
Patch #12 is also a small cleanup.
This series has been tested with a 'make headers_install' on x86 and a
'make headers_install_all'. I've checked the result of both commands.
This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1).
I didn't find any conflict with v4.11-rc4.
v10 -> v11:
- patch #1: restore the double '_' in the header guard
- patch #6, #7, #8: order '#include' in alphabetical order
- patch #10: rename header-n to no-export-headers
cleanup management of kvm.h, kvm_para.h and a.out.h
- patch #12: add it
- rebase on top of masahiroy/linux-kbuild.git#for-next
v9 -> v10:
- rebase on top of masahiroy/linux-kbuild.git#for-next
- patch #4 & #10: fix dependency check
- fix some typos in commits logs
v8 -> v9:
- rebase on top of linus tree
- patch #8: add include/uapi/linux/crypto.h
v7 -> v8:
- rebase on top of linus tree
- add patch #7, #8 and #9
v6 -> v7:
- rebase on top of linus tree
- patch #7: remove autogenerated files from the list in the commit log
v5 -> v6:
- patch #6: remove change of include/uapi/linux/media.h
- patch #7: fix hdr export when 'make O=' is used (look for genhdr files in
the right directory)
- patch #8: fix 'make headers_check'
v4 -> v5:
- patch #3: get back to v3 (don't export msr-index.h)
- patch #6: new in this version
- patch #7: fix compilation by introducing header-n
v3 -> v4:
- first patch has been included
- patch #4: get back to v2 and remove arch/x86/include/asm/msr-index.h
v2 -> v3:
- patch #1: remove arch/arm/include/asm/types.h
- patch #2: remove arch/h8300/include/asm/bitsperlong.h
- patch #3: remove arch/nios2/include/uapi/asm/setup.h
- patch #4: don't export msr-index.h
- patch #5: fix a typo: s/unput-files3-name/input-files3-name
- patch #6: no change
- patch #7: fix include/uapi/asm-generic/Kbuild.asm by introducing mandatory-y
- add patch #8
v1 -> v2:
- add patch #1 to #6
- patch #7: remove use of header-y
Comments are welcomed,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nicolas, 2017-03-27 18:45 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: >> I wanted to leave comments/questions on 10/11, >> but I could not find 10/11 in my mailbox. I do not know why. > Note that you can download the mail from the kbuild patchwork, open it with your > email client and do a reply ;-) I took the patch from the patchwork for git-am, but I was too lazy to import it to my mailer. I will try it next time. Thanks for the tip!
2017-03-27 21:20 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > > > Patches #1 and #2 are just cleanup: some exported headers were still under > a non-uapi directory. Patch #3 is a fix to avoid exporting a file that was > not under an uapi directory. > After these three patches, all exported headers are under an uapi directory: > path #4 stops searching files in non uapi directories. > The patch #5 was spotted by code review: there is no in-tree user of this > functionality. > Patch #6 fixes some warnings/errors reported by 0-day tests. > Patch #7 to #9 fix some errors when the corresponding files are included by > userland. > Patches #10 and #11 remove the need to list explicitly headers. Now all files > under an uapi directory are exported. > Patch #12 is also a small cleanup. > > This series has been tested with a 'make headers_install' on x86 and a > 'make headers_install_all'. I've checked the result of both commands. > > This patch is built on top of masahiroy/linux-kbuild.git#for-next (v4.11-rc1). > I didn't find any conflict with v4.11-rc4. > > v10 -> v11: > - patch #1: restore the double '_' in the header guard > - patch #6, #7, #8: order '#include' in alphabetical order > - patch #10: rename header-n to no-export-headers > cleanup management of kvm.h, kvm_para.h and a.out.h > - patch #12: add it > - rebase on top of masahiroy/linux-kbuild.git#for-next Series, applied to linux-kbuild/uapi. Thanks!
diff --git a/include/linux/crypto.h b/include/linux/crypto.h index c0b0cf3d2d2f..4cf29a35bb4b 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -24,6 +24,7 @@ #include <linux/slab.h> #include <linux/string.h> #include <linux/uaccess.h> +#include <uapi/linux/cryptouser.h> /* * Autoloaded crypto modules should only use a prefixed name to avoid allowing @@ -123,7 +124,6 @@ /* * Miscellaneous stuff. */ -#define CRYPTO_MAX_ALG_NAME 64 /* * The macro CRYPTO_MINALIGN_ATTR (along with the void * type in the actual diff --git a/include/uapi/linux/cryptouser.h b/include/uapi/linux/cryptouser.h index c6a09c5261e7..05fcf1393b4d 100644 --- a/include/uapi/linux/cryptouser.h +++ b/include/uapi/linux/cryptouser.h @@ -18,6 +18,9 @@ * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. */ +#ifndef _UAPI_CRYPTOUSER_H +#define _UAPI_CRYPTOUSER_H + #include <linux/types.h> /* Netlink configuration messages. */ @@ -54,6 +57,8 @@ enum crypto_attr_type_t { #define CRYPTOCFGA_MAX (__CRYPTOCFGA_MAX - 1) }; +#define CRYPTO_MAX_ALG_NAME 64 + struct crypto_user_alg { char cru_name[CRYPTO_MAX_ALG_NAME]; char cru_driver_name[CRYPTO_MAX_ALG_NAME]; @@ -121,3 +126,5 @@ struct crypto_report_acomp { #define CRYPTO_REPORT_MAXSIZE (sizeof(struct crypto_user_alg) + \ sizeof(struct crypto_report_blkcipher)) + +#endif /* _UAPI_CRYPTOUSER_H */
This patch prepares the uapi export by fixing the following error: .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here (not in a function) char cru_name[CRYPTO_MAX_ALG_NAME]; Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- include/linux/crypto.h | 2 +- include/uapi/linux/cryptouser.h | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-)