| Message ID | 1489496093-15315-8-git-send-email-nicolas.dichtel@6wind.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Nicolas, 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > This patch prepares the uapi export by fixing the following errors: > > .../linux/btrfs_tree.h:283:2: error: #error "UUID items require BTRFS_UUID_SIZE == 16!" > #error "UUID items require BTRFS_UUID_SIZE == 16!" > > .../linux/btrfs_tree.h:390:12: error: ‘BTRFS_UUID_SIZE’ undeclared here (not in a function) > __u8 uuid[BTRFS_UUID_SIZE]; > ^ > .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) > __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > include/uapi/linux/btrfs_tree.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h > index 6a261cb52d95..6a754ada59af 100644 > --- a/include/uapi/linux/btrfs_tree.h > +++ b/include/uapi/linux/btrfs_tree.h > @@ -2,6 +2,7 @@ > #define _BTRFS_CTREE_H_ > > #include <linux/types.h> > +#include <linux/btrfs.h> > Can you move <linux/types.h> below <linux/btrfs.h> to sort the includes alphabetically? This also applies to: include/uapi/linux/qrtr.h in 06/11 include/uapi/linux/cryptouser.h in 08/11
Hi Masahiro, Le 27/03/2017 à 07:53, Masahiro Yamada a écrit : > Hi Nicolas, > > > 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: [snip] >> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h >> index 6a261cb52d95..6a754ada59af 100644 >> --- a/include/uapi/linux/btrfs_tree.h >> +++ b/include/uapi/linux/btrfs_tree.h >> @@ -2,6 +2,7 @@ >> #define _BTRFS_CTREE_H_ >> >> #include <linux/types.h> >> +#include <linux/btrfs.h> >> > > Can you move <linux/types.h> below <linux/btrfs.h> > to sort the includes alphabetically? Ok. > > This also applies to: > > include/uapi/linux/qrtr.h in 06/11 > include/uapi/linux/cryptouser.h in 08/11 Ok. Regards, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h index 6a261cb52d95..6a754ada59af 100644 --- a/include/uapi/linux/btrfs_tree.h +++ b/include/uapi/linux/btrfs_tree.h @@ -2,6 +2,7 @@ #define _BTRFS_CTREE_H_ #include <linux/types.h> +#include <linux/btrfs.h> /* * This header contains the structure definitions and constants used
This patch prepares the uapi export by fixing the following errors: .../linux/btrfs_tree.h:283:2: error: #error "UUID items require BTRFS_UUID_SIZE == 16!" #error "UUID items require BTRFS_UUID_SIZE == 16!" .../linux/btrfs_tree.h:390:12: error: ‘BTRFS_UUID_SIZE’ undeclared here (not in a function) __u8 uuid[BTRFS_UUID_SIZE]; ^ .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- include/uapi/linux/btrfs_tree.h | 1 + 1 file changed, 1 insertion(+)