diff mbox

[1/1] IB/rxe: add the static type to the variable

Message ID 1515326928-22282-1-git-send-email-yanjun.zhu@oracle.com (mailing list archive)
State Accepted
Headers show

Commit Message

Zhu Yanjun Jan. 7, 2018, 12:08 p.m. UTC 
The variable recv_sockets is only used in the file rxe_net.c. So
it is better to add static type to it.

CC: Srinivas Eeda <srinivas.eeda@oracle.com>
CC: Joe Jin <joe.jin@oracle.com>
CC: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
---
 drivers/infiniband/sw/rxe/rxe_net.c | 2 +-
 drivers/infiniband/sw/rxe/rxe_net.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Leon Romanovsky Jan. 7, 2018, 1:38 p.m. UTC | #1 
On Sun, Jan 07, 2018 at 07:08:48AM -0500, Zhu Yanjun wrote:
> The variable recv_sockets is only used in the file rxe_net.c. So
> it is better to add static type to it.
>
> CC: Srinivas Eeda <srinivas.eeda@oracle.com>
> CC: Joe Jin <joe.jin@oracle.com>
> CC: Junxiao Bi <junxiao.bi@oracle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_net.c | 2 +-
>  drivers/infiniband/sw/rxe/rxe_net.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Doug Ledford Jan. 8, 2018, 10:45 p.m. UTC | #2 
On Sun, 2018-01-07 at 15:38 +0200, Leon Romanovsky wrote:
> On Sun, Jan 07, 2018 at 07:08:48AM -0500, Zhu Yanjun wrote:
> > The variable recv_sockets is only used in the file rxe_net.c. So
> > it is better to add static type to it.
> > 
> > CC: Srinivas Eeda <srinivas.eeda@oracle.com>
> > CC: Joe Jin <joe.jin@oracle.com>
> > CC: Junxiao Bi <junxiao.bi@oracle.com>
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> > ---
> >  drivers/infiniband/sw/rxe/rxe_net.c | 2 +-
> >  drivers/infiniband/sw/rxe/rxe_net.h | 1 -
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index 59dee10..44d7780 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -82,7 +82,7 @@  struct rxe_dev *get_rxe_by_name(const char *name)
 }
 
 
-struct rxe_recv_sockets recv_sockets;
+static struct rxe_recv_sockets recv_sockets;
 
 struct device *rxe_dma_device(struct rxe_dev *rxe)
 {
diff --git a/drivers/infiniband/sw/rxe/rxe_net.h b/drivers/infiniband/sw/rxe/rxe_net.h
index 1c06b3b..728d8c7 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.h
+++ b/drivers/infiniband/sw/rxe/rxe_net.h
@@ -43,7 +43,6 @@  struct rxe_recv_sockets {
 	struct socket *sk6;
 };
 
-extern struct rxe_recv_sockets recv_sockets;
 extern struct notifier_block rxe_net_notifier;
 void rxe_release_udp_tunnel(struct socket *sk);