| Message ID | 1523276358-2800-1-git-send-email-yanjun.zhu@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Apr 09, 2018 at 08:19:18AM -0400, Zhu Yanjun wrote: > The function rxe_release_udp_tunnel is only used in rxe_net.c. > So it is necessary to make this function as static. > > CC: Srinivas Eeda <srinivas.eeda@oracle.com> > CC: Junxiao Bi <junxiao.bi@oracle.com> > Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > drivers/infiniband/sw/rxe/rxe_net.c | 2 +- > drivers/infiniband/sw/rxe/rxe_net.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c > index 9da6e37..b0e7919 100644 > --- a/drivers/infiniband/sw/rxe/rxe_net.c > +++ b/drivers/infiniband/sw/rxe/rxe_net.c > @@ -315,7 +315,7 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, > return sock; > } > > -void rxe_release_udp_tunnel(struct socket *sk) > +static void rxe_release_udp_tunnel(struct socket *sk) > { > if (sk) > udp_tunnel_sock_release(sk); > diff --git a/drivers/infiniband/sw/rxe/rxe_net.h b/drivers/infiniband/sw/rxe/rxe_net.h > index 728d8c7..3b7a58a 100644 > --- a/drivers/infiniband/sw/rxe/rxe_net.h > +++ b/drivers/infiniband/sw/rxe/rxe_net.h > @@ -44,7 +44,6 @@ struct rxe_recv_sockets { > }; > > extern struct notifier_block rxe_net_notifier; > -void rxe_release_udp_tunnel(struct socket *sk); > > struct rxe_dev *rxe_net_add(struct net_device *ndev); > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2018-04-09 at 20:20 +0300, Yuval Shaia wrote: > On Mon, Apr 09, 2018 at 08:19:18AM -0400, Zhu Yanjun wrote: > > The function rxe_release_udp_tunnel is only used in rxe_net.c. > > So it is necessary to make this function as static. > > > > CC: Srinivas Eeda <srinivas.eeda@oracle.com> > > CC: Junxiao Bi <junxiao.bi@oracle.com> > > Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> > > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Thanks, applied to for-next.
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index 9da6e37..b0e7919 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -315,7 +315,7 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, return sock; } -void rxe_release_udp_tunnel(struct socket *sk) +static void rxe_release_udp_tunnel(struct socket *sk) { if (sk) udp_tunnel_sock_release(sk); diff --git a/drivers/infiniband/sw/rxe/rxe_net.h b/drivers/infiniband/sw/rxe/rxe_net.h index 728d8c7..3b7a58a 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.h +++ b/drivers/infiniband/sw/rxe/rxe_net.h @@ -44,7 +44,6 @@ struct rxe_recv_sockets { }; extern struct notifier_block rxe_net_notifier; -void rxe_release_udp_tunnel(struct socket *sk); struct rxe_dev *rxe_net_add(struct net_device *ndev);
The function rxe_release_udp_tunnel is only used in rxe_net.c. So it is necessary to make this function as static. CC: Srinivas Eeda <srinivas.eeda@oracle.com> CC: Junxiao Bi <junxiao.bi@oracle.com> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> --- drivers/infiniband/sw/rxe/rxe_net.c | 2 +- drivers/infiniband/sw/rxe/rxe_net.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)