| Message ID | 1526009610-72089-5-git-send-email-oulijun@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
On Fri, May 11, 2018 at 11:33:28AM +0800, Lijun Ou wrote: > When generated bad work reqeust, it needs to > report to user. This patch mainly fixes it. > > Signed-off-by: Lijun Ou <oulijun@huawei.com> > --- > providers/hns/hns_roce_u_hw_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c > index 06830ac..42bd5dd 100644 > --- a/providers/hns/hns_roce_u_hw_v2.c > +++ b/providers/hns/hns_roce_u_hw_v2.c > @@ -695,7 +695,7 @@ static int hns_roce_u_v2_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, > *bad_wr = wr; > printf("data len=%d, send_flags = 0x%x!\r\n", > rc_sq_wqe->msg_len, wr->send_flags); > - return ret; > + goto out; No prints in drivers, please send a patch removing all of the printfs and fprintfs You can have opt-in debug scheme, like mlx5, that would be some good code to move into util/ Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
在 2018/5/17 1:31, Jason Gunthorpe 写道: > On Fri, May 11, 2018 at 11:33:28AM +0800, Lijun Ou wrote: >> When generated bad work reqeust, it needs to >> report to user. This patch mainly fixes it. >> >> Signed-off-by: Lijun Ou <oulijun@huawei.com> >> --- >> providers/hns/hns_roce_u_hw_v2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c >> index 06830ac..42bd5dd 100644 >> --- a/providers/hns/hns_roce_u_hw_v2.c >> +++ b/providers/hns/hns_roce_u_hw_v2.c >> @@ -695,7 +695,7 @@ static int hns_roce_u_v2_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, >> *bad_wr = wr; >> printf("data len=%d, send_flags = 0x%x!\r\n", >> rc_sq_wqe->msg_len, wr->send_flags); >> - return ret; >> + goto out; > > No prints in drivers, please send a patch removing all of the printfs > and fprintfs > > You can have opt-in debug scheme, like mlx5, that would be some good > code to move into util/ > Thanks, I will do it in fixup patch. > Thanks, > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c index 06830ac..42bd5dd 100644 --- a/providers/hns/hns_roce_u_hw_v2.c +++ b/providers/hns/hns_roce_u_hw_v2.c @@ -695,7 +695,7 @@ static int hns_roce_u_v2_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, *bad_wr = wr; printf("data len=%d, send_flags = 0x%x!\r\n", rc_sq_wqe->msg_len, wr->send_flags); - return ret; + goto out; } if (wr->opcode == IBV_WR_RDMA_READ) {
When generated bad work reqeust, it needs to report to user. This patch mainly fixes it. Signed-off-by: Lijun Ou <oulijun@huawei.com> --- providers/hns/hns_roce_u_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)