| Message ID | 1546874876-24589-1-git-send-email-galpress@amazon.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4959d5da5737dd804255c75b8cea0a2929ce279a |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [rdma-next,1/3] IB/usnic: Fix out of bounds index check in query pkey | expand |
Thanks, Acked-by: Parvi Kaustubhi <pkaustub@cisco.com> > On Jan 7, 2019, at 7:27 AM, Gal Pressman <galpress@amazon.com> wrote: > > The pkey table size is one element, index should be tested for > 0 > instead of > 1. > > Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") > Cc: Christian Benvenuti <benve@cisco.com> > Cc: Nelson Escobar <neescoba@cisco.com> > Cc: Parvi Kaustubhi <pkaustub@cisco.com> > Signed-off-by: Gal Pressman <galpress@amazon.com> > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c > index 1d4abef17e38..63c7b48774e9 100644 > --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c > +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c > @@ -449,7 +449,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num) > int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index, > u16 *pkey) > { > - if (index > 1) > + if (index > 0) > return -EINVAL; > > *pkey = 0xffff; > -- > 2.7.4 >
On Mon, Jan 07, 2019 at 05:27:54PM +0200, Gal Pressman wrote: > The pkey table size is one element, index should be tested for > 0 > instead of > 1. > > Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") > Cc: Christian Benvenuti <benve@cisco.com> > Cc: Nelson Escobar <neescoba@cisco.com> > Cc: Parvi Kaustubhi <pkaustub@cisco.com> > Signed-off-by: Gal Pressman <galpress@amazon.com> > Acked-by: Parvi Kaustubhi <pkaustub@cisco.com> > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied this series to for-next thanks Jason
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1d4abef17e38..63c7b48774e9 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c @@ -449,7 +449,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num) int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16 *pkey) { - if (index > 1) + if (index > 0) return -EINVAL; *pkey = 0xffff;
The pkey table size is one element, index should be tested for > 0 instead of > 1. Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") Cc: Christian Benvenuti <benve@cisco.com> Cc: Nelson Escobar <neescoba@cisco.com> Cc: Parvi Kaustubhi <pkaustub@cisco.com> Signed-off-by: Gal Pressman <galpress@amazon.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)