From patchwork Wed Nov 4 22:06:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiong, Jianxin" X-Patchwork-Id: 11882193 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 061641130 for ; Wed, 4 Nov 2020 21:52:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E374920867 for ; Wed, 4 Nov 2020 21:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731555AbgKDVwv (ORCPT ); Wed, 4 Nov 2020 16:52:51 -0500 Received: from mga14.intel.com ([192.55.52.115]:38125 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbgKDVwu (ORCPT ); Wed, 4 Nov 2020 16:52:50 -0500 IronPort-SDR: Z+gglBNVG+kesLS4ojTWHn2UX5rn5/ihjYP8KHlZyKgIttxMuppFfHCvtlLH4yRdgtBhXJgX3l r90Ru7ClPZdg== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="168509131" X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="168509131" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 13:52:50 -0800 IronPort-SDR: C9MOXJm3X0rNZZJjsTDOe3LaO9GKRqbWJMz2y4xhmZcNlqWJY4aZTIt4qbqu4tS2nO73l4helU 3Jwe7I7VIFyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="337019424" Received: from cst-dev.jf.intel.com ([10.23.221.69]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2020 13:52:50 -0800 From: Jianxin Xiong To: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Jianxin Xiong , Doug Ledford , Jason Gunthorpe , Leon Romanovsky , Sumit Semwal , Christian Koenig , Daniel Vetter Subject: [PATCH v7 5/5] dma-buf: Reject attach request from importers that use dma_virt_ops Date: Wed, 4 Nov 2020 14:06:35 -0800 Message-Id: <1604527595-39736-6-git-send-email-jianxin.xiong@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1604527595-39736-1-git-send-email-jianxin.xiong@intel.com> References: <1604527595-39736-1-git-send-email-jianxin.xiong@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org dma_virt_ops is used by virtual devices that map pages / scatterlists to virtual addresses for CPU access instead of performing DMA. This is not the intended use of dma_buf_attach() and dma_buf_map_attachment(). CPU access of dma-buf should use dma_buf_vmap() and related functions. Signed-off-by: Jianxin Xiong --- drivers/dma-buf/dma-buf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 9a054fb5..ba2b877 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -686,6 +686,11 @@ struct dma_buf_attachment * if (WARN_ON(importer_ops && !importer_ops->move_notify)) return ERR_PTR(-EINVAL); +#ifdef CONFIG_DMA_VIRT_OPS + if (dev->dma_ops == &dma_virt_ops) + return ERR_PTR(-EINVAL); +#endif + attach = kzalloc(sizeof(*attach), GFP_KERNEL); if (!attach) return ERR_PTR(-ENOMEM);