From patchwork Thu Feb 4 18:50:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiong, Jianxin" X-Patchwork-Id: 12068371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9199C433DB for ; Thu, 4 Feb 2021 18:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7864564E4F for ; Thu, 4 Feb 2021 18:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239259AbhBDSlb (ORCPT ); Thu, 4 Feb 2021 13:41:31 -0500 Received: from mga01.intel.com ([192.55.52.88]:43872 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238757AbhBDSj0 (ORCPT ); Thu, 4 Feb 2021 13:39:26 -0500 IronPort-SDR: Rb9YWWIC3yz/QS7kBBcQSsAJy29DHCBtNz6ZDfXVxuKd3Ns41gXaQe1mmX5YWHT9Nl5srGMz91 TTj6KzBou/+w== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="200296768" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="200296768" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 10:35:59 -0800 IronPort-SDR: wNSpWYdSiQZTpEk8tiZ2sSLkVDrfKFn7TxPyS0CSd9XOJqa4rUaT7SR/veJZ7vExpiM+sX2VPx s27d41rCzccw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="580383251" Received: from cst-dev.jf.intel.com ([10.23.221.69]) by fmsmga006.fm.intel.com with ESMTP; 04 Feb 2021 10:35:59 -0800 From: Jianxin Xiong To: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Jianxin Xiong , Doug Ledford , Jason Gunthorpe , Leon Romanovsky , Sumit Semwal , Christian Koenig , Daniel Vetter , Edward Srouji , Yishai Hadas , John Hubbard , Ali Alnubani , Gal Pressman , Emil Velikov Subject: [PATCH rdma-core 3/3] configure: Add check for the presence of DRM headers Date: Thu, 4 Feb 2021 10:50:51 -0800 Message-Id: <1612464651-54073-4-git-send-email-jianxin.xiong@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1612464651-54073-1-git-send-email-jianxin.xiong@intel.com> References: <1612464651-54073-1-git-send-email-jianxin.xiong@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Compilation of pyverbs/dmabuf_alloc.c depends on a few DRM headers that are installed by either the kernel-header or the libdrm package. The installation is optional and the location is not unique. The standard locations (such as /usr/include/drm, /usr/include/libdrm) are checked first. If failed, pkg-config is tried to find the include path of custom libdrm installation. The dmabuf allocation routines now return suitable error when the headers are not available. The related tests will recognize this error code and skip. Signed-off-by: Jianxin Xiong --- CMakeLists.txt | 7 +++++++ buildlib/Finddrm.cmake | 19 +++++++++++++++++++ buildlib/config.h.in | 2 ++ pyverbs/dmabuf_alloc.c | 47 ++++++++++++++++++++++++++++++++++++++++++----- 4 files changed, 70 insertions(+), 5 deletions(-) create mode 100644 buildlib/Finddrm.cmake diff --git a/CMakeLists.txt b/CMakeLists.txt index 4113423..feaba3a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -515,6 +515,13 @@ find_package(Systemd) include_directories(${SYSTEMD_INCLUDE_DIRS}) RDMA_DoFixup("${SYSTEMD_FOUND}" "systemd/sd-daemon.h") +# drm headers +find_package(drm) +if (DRM_INCLUDE_DIRS) + include_directories(${DRM_INCLUDE_DIRS}) + set(HAVE_DRM_H 1) +endif() + #------------------------- # Apply fixups diff --git a/buildlib/Finddrm.cmake b/buildlib/Finddrm.cmake new file mode 100644 index 0000000..6f8e5f2 --- /dev/null +++ b/buildlib/Finddrm.cmake @@ -0,0 +1,19 @@ +# COPYRIGHT (c) 2021 Intel Corporation. +# Licensed under BSD (MIT variant) or GPLv2. See COPYING. + +# Check standard locations first +find_path(DRM_INCLUDE_DIRS "drm.h" PATH_SUFFIXES "drm" "libdrm") + +# Check custom libdrm installation, if any +if (NOT DRM_INCLUDE_DIRS) + execute_process(COMMAND pkg-config --cflags-only-I libdrm + OUTPUT_VARIABLE _LIBDRM + RESULT_VARIABLE _LIBDRM_RESULT + ERROR_QUIET) + + if (NOT _LIBDRM_RESULT) + string(REGEX REPLACE "^-I" "" DRM_INCLUDE_DIRS "${_LIBDRM}") + endif() + unset(_LIBDRM) + unset(_LIBDRM_RESULT) +endif() diff --git a/buildlib/config.h.in b/buildlib/config.h.in index c5b0bf5..e8dff54 100644 --- a/buildlib/config.h.in +++ b/buildlib/config.h.in @@ -67,6 +67,8 @@ # define VERBS_WRITE_ONLY 0 #endif +#define HAVE_DRM_H @HAVE_DRM_H@ + // Configuration defaults #define IBACM_SERVER_MODE_UNIX 0 diff --git a/pyverbs/dmabuf_alloc.c b/pyverbs/dmabuf_alloc.c index 93267bf..22a8ab8 100644 --- a/pyverbs/dmabuf_alloc.c +++ b/pyverbs/dmabuf_alloc.c @@ -9,13 +9,18 @@ #include #include #include -#include -#include -#include -#include + +#include "config.h" +#include "dmabuf_alloc.h" + +#if HAVE_DRM_H + +#include +#include +#include +#include #include #include -#include "dmabuf_alloc.h" /* * Abstraction of the buffer allocation mechanism using the DRM interface. @@ -276,3 +281,35 @@ uint64_t dmabuf_get_offset(struct dmabuf *dmabuf) return dmabuf->map_offset; } +#else + +struct dmabuf *dmabuf_alloc(uint64_t size, int gpu, int gtt) +{ + errno = EOPNOTSUPP; + return NULL; +} + +void dmabuf_free(struct dmabuf *dmabuf) +{ + errno = EOPNOTSUPP; +} + +int dmabuf_get_drm_fd(struct dmabuf *dmabuf) +{ + errno = EOPNOTSUPP; + return -1; +} + +int dmabuf_get_fd(struct dmabuf *dmabuf) +{ + errno = EOPNOTSUPP; + return -1; +} + +uint64_t dmabuf_get_offset(struct dmabuf *dmabuf) +{ + errno = EOPNOTSUPP; + return -1; +} + +#endif