| Message ID | 1620807142-39157-5-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA: Remove unused parameter udata | expand |
On Wed, May 12, 2021 at 4:14 PM Weihang Li <liweihang@huawei.com> wrote: > > From: Lang Cheng <chenglang@huawei.com> > > The old version of ib_umem_get() need these udata as a parameter but now > they are unnecessary. > > Fixes: c320e527e154 ("IB: Allow calls to ib_umem_get from kernel ULPs") > Cc: Zhu Yanjun <zyjzyj2000@gmail.com> Thanks. I am fine with this. Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com> Zhu Yanjun > Signed-off-by: Lang Cheng <chenglang@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> > --- > drivers/infiniband/sw/rxe/rxe_loc.h | 2 +- > drivers/infiniband/sw/rxe/rxe_mr.c | 2 +- > drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h > index ef8061d..b21038c 100644 > --- a/drivers/infiniband/sw/rxe/rxe_loc.h > +++ b/drivers/infiniband/sw/rxe/rxe_loc.h > @@ -79,7 +79,7 @@ enum copy_direction { > void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr); > > int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, > - int access, struct ib_udata *udata, struct rxe_mr *mr); > + int access, struct rxe_mr *mr); > > int rxe_mr_init_fast(struct rxe_pd *pd, int max_pages, struct rxe_mr *mr); > > diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c > index 9f63947..373b46aa 100644 > --- a/drivers/infiniband/sw/rxe/rxe_mr.c > +++ b/drivers/infiniband/sw/rxe/rxe_mr.c > @@ -121,7 +121,7 @@ void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr) > } > > int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, > - int access, struct ib_udata *udata, struct rxe_mr *mr) > + int access, struct rxe_mr *mr) > { > struct rxe_map **map; > struct rxe_phys_buf *buf = NULL; > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c > index aeb5e23..86a0965 100644 > --- a/drivers/infiniband/sw/rxe/rxe_verbs.c > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c > @@ -899,7 +899,7 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, > > rxe_add_ref(pd); > > - err = rxe_mr_init_user(pd, start, length, iova, access, udata, mr); > + err = rxe_mr_init_user(pd, start, length, iova, access, mr); > if (err) > goto err3; > > -- > 2.7.4 >
On Wed, May 12, 2021 at 04:12:22PM +0800, Weihang Li wrote: > From: Lang Cheng <chenglang@huawei.com> > > The old version of ib_umem_get() need these udata as a parameter but now > they are unnecessary. > > Fixes: c320e527e154 ("IB: Allow calls to ib_umem_get from kernel ULPs") > Cc: Zhu Yanjun <zyjzyj2000@gmail.com> > Signed-off-by: Lang Cheng <chenglang@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> > --- > drivers/infiniband/sw/rxe/rxe_loc.h | 2 +- > drivers/infiniband/sw/rxe/rxe_mr.c | 2 +- > drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h index ef8061d..b21038c 100644 --- a/drivers/infiniband/sw/rxe/rxe_loc.h +++ b/drivers/infiniband/sw/rxe/rxe_loc.h @@ -79,7 +79,7 @@ enum copy_direction { void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr); int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, - int access, struct ib_udata *udata, struct rxe_mr *mr); + int access, struct rxe_mr *mr); int rxe_mr_init_fast(struct rxe_pd *pd, int max_pages, struct rxe_mr *mr); diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c index 9f63947..373b46aa 100644 --- a/drivers/infiniband/sw/rxe/rxe_mr.c +++ b/drivers/infiniband/sw/rxe/rxe_mr.c @@ -121,7 +121,7 @@ void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr) } int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, - int access, struct ib_udata *udata, struct rxe_mr *mr) + int access, struct rxe_mr *mr) { struct rxe_map **map; struct rxe_phys_buf *buf = NULL; diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c index aeb5e23..86a0965 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.c +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c @@ -899,7 +899,7 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, rxe_add_ref(pd); - err = rxe_mr_init_user(pd, start, length, iova, access, udata, mr); + err = rxe_mr_init_user(pd, start, length, iova, access, mr); if (err) goto err3;