| Message ID | 1623392089-35639-1-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [v3,for-next] RDMA/hns: Clear extended doorbell info before using | expand |
On Fri, Jun 11, 2021 at 02:14:49PM +0800, Weihang Li wrote: > From: Xi Wang <wangxi11@huawei.com> > > Both of HIP08 and HIP09 require the extended doorbell information to be > cleared before being used. > > Fixes: 6b63597d3540 ("RDMA/hns: Add TSQ link table support") > Signed-off-by: Xi Wang <wangxi11@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> > --- > Changes since v2: > - Clear ext doorbell list info before get_hem_table(). > - Link: https://patchwork.kernel.org/project/linux-rdma/patch/1623323990-62343-1-git-send-email-liweihang@huawei.com/ > > Changes since v1: > - Add fixes tag. > - Add check for return value of hns_roce_clear_extdb_list_info(). > - Link: https://patchwork.kernel.org/project/linux-rdma/patch/1623237065-43344-1-git-send-email-liweihang@huawei.com/ > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 21 +++++++++++++++++++++ > drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 1 + > 2 files changed, 22 insertions(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Fri, Jun 11, 2021 at 02:14:49PM +0800, Weihang Li wrote: > From: Xi Wang <wangxi11@huawei.com> > > Both of HIP08 and HIP09 require the extended doorbell information to be > cleared before being used. > > Fixes: 6b63597d3540 ("RDMA/hns: Add TSQ link table support") > Signed-off-by: Xi Wang <wangxi11@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > Changes since v2: > - Clear ext doorbell list info before get_hem_table(). > - Link: https://patchwork.kernel.org/project/linux-rdma/patch/1623323990-62343-1-git-send-email-liweihang@huawei.com/ > > Changes since v1: > - Add fixes tag. > - Add check for return value of hns_roce_clear_extdb_list_info(). > - Link: https://patchwork.kernel.org/project/linux-rdma/patch/1623237065-43344-1-git-send-email-liweihang@huawei.com/ > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 21 +++++++++++++++++++++ > drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 1 + > 2 files changed, 22 insertions(+) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index fbc45b9..d3fe9ee 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -1572,6 +1572,22 @@ static void hns_roce_function_clear(struct hns_roce_dev *hr_dev) } } +static int hns_roce_clear_extdb_list_info(struct hns_roce_dev *hr_dev) +{ + struct hns_roce_cmq_desc desc; + int ret; + + hns_roce_cmq_setup_basic_desc(&desc, HNS_ROCE_OPC_CLEAR_EXTDB_LIST_INFO, + false); + ret = hns_roce_cmq_send(hr_dev, &desc, 1); + if (ret) + ibdev_err(&hr_dev->ib_dev, + "failed to clear extended doorbell info, ret = %d.\n", + ret); + + return ret; +} + static int hns_roce_query_fw_ver(struct hns_roce_dev *hr_dev) { struct hns_roce_query_fw_info *resp; @@ -2680,6 +2696,11 @@ static int hns_roce_v2_init(struct hns_roce_dev *hr_dev) { int ret; + /* The hns ROCEE requires the extdb info to be cleared before using */ + ret = hns_roce_clear_extdb_list_info(hr_dev); + if (ret) + return ret; + ret = get_hem_table(hr_dev); if (ret) return ret; diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h b/drivers/infiniband/hw/hns/hns_roce_hw_v2.h index cd361c0..073e835 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.h @@ -250,6 +250,7 @@ enum hns_roce_opcode_type { HNS_ROCE_OPC_CLR_SCCC = 0x8509, HNS_ROCE_OPC_QUERY_SCCC = 0x850a, HNS_ROCE_OPC_RESET_SCCC = 0x850b, + HNS_ROCE_OPC_CLEAR_EXTDB_LIST_INFO = 0x850d, HNS_ROCE_OPC_QUERY_VF_RES = 0x850e, HNS_ROCE_OPC_CFG_GMV_TBL = 0x850f, HNS_ROCE_OPC_CFG_GMV_BT = 0x8510,