| Message ID | 1638439679-114250-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA/siw: Use max() instead of doing it manually | expand |
-----"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com> wrote: ----- >To: bmt@zurich.ibm.com >From: "Jiapeng Chong" <jiapeng.chong@linux.alibaba.com> >Date: 12/02/2021 11:08AM >Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, >linux-kernel@vger.kernel.org, "Jiapeng Chong" ><jiapeng.chong@linux.alibaba.com> >Subject: [EXTERNAL] [PATCH] RDMA/siw: Use max() instead of doing it >manually > >Fix following coccicheck warning: > >./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING >opportunity >for max(). > >Reported-by: Abaci Robot <abaci@linux.alibaba.com> >Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >--- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/infiniband/sw/siw/siw_verbs.c >b/drivers/infiniband/sw/siw/siw_verbs.c >index d15a1f9..a3dd2cb 100644 >--- a/drivers/infiniband/sw/siw/siw_verbs.c >+++ b/drivers/infiniband/sw/siw/siw_verbs.c >@@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct >ib_send_wr *core_wr, > kbuf += core_sge->length; > core_sge++; > } >- sqe->sge[0].length = bytes > 0 ? bytes : 0; >+ sqe->sge[0].length = max(bytes, 0); > sqe->num_sge = bytes > 0 ? 1 : 0; > > return bytes; >-- >1.8.3.1 > > Looks good, thanks! Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
On Thu, Dec 02, 2021 at 06:07:59PM +0800, Jiapeng Chong wrote: > Fix following coccicheck warning: > > ./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING opportunity > for max(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com> > --- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c index d15a1f9..a3dd2cb 100644 --- a/drivers/infiniband/sw/siw/siw_verbs.c +++ b/drivers/infiniband/sw/siw/siw_verbs.c @@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct ib_send_wr *core_wr, kbuf += core_sge->length; core_sge++; } - sqe->sge[0].length = bytes > 0 ? bytes : 0; + sqe->sge[0].length = max(bytes, 0); sqe->num_sge = bytes > 0 ? 1 : 0; return bytes;
Fix following coccicheck warning: ./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING opportunity for max(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/infiniband/sw/siw/siw_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)