| Message ID | 1645106372-23004-1-git-send-email-mike.marciniszyn@cornelisnetworks.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-rc] IB/qib: Fix duplicate sysfs directory name | expand |
On Thu, Feb 17, 2022 at 08:59:32AM -0500, mike.marciniszyn@cornelisnetworks.com wrote: > From: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com> > > The qib driver load has been failing with the > following message: > > [ 21.186138] sysfs: cannot create duplicate filename '/devices/pci0000:80/0000:80:02.0/0000:81:00.0/infiniband/qib0/ports/1/linkcontrol' > > The patch below has two "linkcontrol" names causing the duplication. > > Fix by using the correct "diag_counters" name on the second instance. > > Fixes: 4a7aaf88c89f ("RDMA/qib: Use attributes for the port sysfs") > Cc: <stable@vger.kernel.org> > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> > Signed-off-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com> > --- > drivers/infiniband/hw/qib/qib_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-rc, thanks Jason
diff --git a/drivers/infiniband/hw/qib/qib_sysfs.c b/drivers/infiniband/hw/qib/qib_sysfs.c index 0a3b281..41c2729 100644 --- a/drivers/infiniband/hw/qib/qib_sysfs.c +++ b/drivers/infiniband/hw/qib/qib_sysfs.c @@ -541,7 +541,7 @@ static ssize_t rc_delayed_comp_store(struct ib_device *ibdev, u32 port_num, }; static const struct attribute_group port_diagc_group = { - .name = "linkcontrol", + .name = "diag_counters", .attrs = port_diagc_attributes, };