From patchwork Tue Jul 1 05:54:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devesh Sharma X-Patchwork-Id: 4456691 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2E2DFBEEAA for ; Tue, 1 Jul 2014 06:30:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 588FE203FB for ; Tue, 1 Jul 2014 06:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5272B203F4 for ; Tue, 1 Jul 2014 06:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbaGAGab (ORCPT ); Tue, 1 Jul 2014 02:30:31 -0400 Received: from cmexedge1.ext.emulex.com ([138.239.224.99]:57916 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbaGAGaa (ORCPT ); Tue, 1 Jul 2014 02:30:30 -0400 Received: from CMEXHTCAS1.ad.emulex.com (138.239.115.217) by CMEXEDGE1.ext.emulex.com (138.239.224.99) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 30 Jun 2014 23:31:03 -0700 Received: from neo01-el64.lab.bg.emulex.com (10.192.204.8) by smtp.emulex.com (138.239.115.207) with Microsoft SMTP Server id 14.3.174.1; Mon, 30 Jun 2014 23:30:25 -0700 From: Devesh Sharma To: CC: Devesh Sharma Subject: [for-next 1/4] RDMA/libocrdma: dont skip setting deffer_arm Date: Tue, 1 Jul 2014 11:24:02 +0530 X-Mailer: git-send-email 1.7.1 In-Reply-To: <1404194045-26900-1-git-send-email-devesh.sharma@emulex.com> References: <1404194045-26900-1-git-send-email-devesh.sharma@emulex.com> MIME-Version: 1.0 Message-ID: <164cabce-25f0-4b23-add4-4d5a88368b7d@CMEXHTCAS1.ad.emulex.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ibv_request_notify_cq() when called for the first time ocrdma tries to skip setting deffered_arm flag. This may lead CQ to an un-armed state thus, never generating CQ event and leaving consumer in hung state. Signed-off-by: Devesh Sharma --- src/ocrdma_verbs.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/ocrdma_verbs.c b/src/ocrdma_verbs.c index 8e0c344..0f138cf 100644 --- a/src/ocrdma_verbs.c +++ b/src/ocrdma_verbs.c @@ -2054,12 +2054,9 @@ int ocrdma_arm_cq(struct ibv_cq *ibcq, int solicited) if (cq->first_arm) { ocrdma_ring_cq_db(cq, 1, solicited, 0); cq->first_arm = 0; - goto skip_defer; } cq->deferred_arm = 1; - -skip_defer: cq->deferred_sol = solicited; pthread_spin_unlock(&cq->cq_lock);