From patchwork Wed Oct 11 18:31:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13417725 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC52CDB479 for ; Wed, 11 Oct 2023 18:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232571AbjJKSn0 (ORCPT ); Wed, 11 Oct 2023 14:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232496AbjJKSnZ (ORCPT ); Wed, 11 Oct 2023 14:43:25 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C290594 for ; Wed, 11 Oct 2023 11:43:24 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c9d7a98abbso1178735ad.1 for ; Wed, 11 Oct 2023 11:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697049804; x=1697654604; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ucTF3XQVAaVTeTqYQhM+UzWxKAWhu0a7HlGrCcLFr3Q=; b=Au3Q2hARL7e97ea8XrPRiyNhHKDTR9x/CNZCasQrM8aFFM0lACtDtmsBAaKX5+klHq +3y5FFQGFm0N05eow2lzbQk25yNZZZNtMh5h1lzTEX0HLmNzeApNkiAH8xY7lfgB2iGg AqtJHnk9N6B0bNvuZacfOl69MKl/S1xFC8rSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697049804; x=1697654604; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ucTF3XQVAaVTeTqYQhM+UzWxKAWhu0a7HlGrCcLFr3Q=; b=T6t90YDAx06RPfreMYBTcmxFKAVh/UoXEiIKow/TKFTYHrflzMHw2TOONn/QzzJX9B Wl6LDQZhrDzYGqF4lsWkV+NEdW6C5zUxDZmJk6JKbbElaqsq8qfFJvTS0ZMeLzQBi+ot c/E/9F7m76WLBgRhmdxDZS1r90vbITG7teGsjtB6UhKhiqhJa7dyInkYXESREgbvi3hl VBqXpIJfEFZoiOGmaONGxaV7eujssMmqHj55xZZPP5knxKjBDAnmZdgQ4YOTm7HPOsVn GfIXN4KGQobtZn9+CTTe9mcIhibGB80yJkGikJ9yeoekZ+ToLW4Ve+BH0x4d6c8ALQCB Uy8Q== X-Gm-Message-State: AOJu0YxEYyaAo9j6RdRZa5EgnMUgclW/qjspvXdUFZMoPdbN1b/rV6vQ sREIA0M/ZiZd5RKcBFuHXAEpHw== X-Google-Smtp-Source: AGHT+IGFIEwWEy7bGFkp3f7fIt25aU4L+W8L45CWMhmqTD8YJBCgeTv0zYgzLfnUC+AJteG5Hy0uAw== X-Received: by 2002:a17:902:e3d1:b0:1c9:d90b:c3e4 with SMTP id r17-20020a170902e3d100b001c9d90bc3e4mr955766ple.10.1697049804200; Wed, 11 Oct 2023 11:43:24 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id b4-20020a170902ed0400b001b89466a5f4sm178887pld.105.2023.10.11.11.43.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2023 11:43:23 -0700 (PDT) From: Selvin Xavier To: jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Chandramohan Akula , Selvin Xavier Subject: [PATCH for-next v2 3/3] RDMA/bnxt_re: Do not report SRQ error in srq notification Date: Wed, 11 Oct 2023 11:31:37 -0700 Message-Id: <1697049097-31992-4-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1697049097-31992-1-git-send-email-selvin.xavier@broadcom.com> References: <1697049097-31992-1-git-send-email-selvin.xavier@broadcom.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Chandramohan Akula In the SRQ notification handler, do not report the SRQ_ERROR in the default event case, as there was no error. Signed-off-by: Chandramohan Akula Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index ae72207..bd3deb2 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1187,13 +1187,10 @@ static int bnxt_re_srqn_handler(struct bnxt_qplib_nq *nq, ib_event.device = &srq->rdev->ibdev; ib_event.element.srq = &srq->ib_srq; - if (event == NQ_SRQ_EVENT_EVENT_SRQ_THRESHOLD_EVENT) - ib_event.event = IB_EVENT_SRQ_LIMIT_REACHED; - else - ib_event.event = IB_EVENT_SRQ_ERR; if (srq->ib_srq.event_handler) { - /* Lock event_handler? */ + if (event == NQ_SRQ_EVENT_EVENT_SRQ_THRESHOLD_EVENT) + ib_event.event = IB_EVENT_SRQ_LIMIT_REACHED; (*srq->ib_srq.event_handler)(&ib_event, srq->ib_srq.srq_context); }