diff mbox series

[v2,1/1] RDMA/mana_ib: ignore optional access flags for MRs

Message ID 1717575368-14879-1-git-send-email-kotaranov@linux.microsoft.com (mailing list archive)
State Accepted
Headers show
Series [v2,1/1] RDMA/mana_ib: ignore optional access flags for MRs | expand

Commit Message

Konstantin Taranov June 5, 2024, 8:16 a.m. UTC 
From: Konstantin Taranov <kotaranov@microsoft.com>

Ignore optional ib_access_flags when an MR is created.

Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
---
 drivers/infiniband/hw/mana/mr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Long Li June 5, 2024, 10:14 p.m. UTC | #1 
> Subject: [PATCH v2 1/1] RDMA/mana_ib: ignore optional access flags for MRs
> 
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Ignore optional ib_access_flags when an MR is created.

Can you add details on why this is needed?
Konstantin Taranov June 6, 2024, 8:30 a.m. UTC | #2 
> > Ignore optional ib_access_flags when an MR is created.
> 
> Can you add details on why this is needed?

Do you mean to the commit message?
If we do not ignore these optional flags, the reg user mr fails because the next 2 lines:
	if (access_flags & ~VALID_MR_FLAGS)
		return ERR_PTR(-EINVAL);
Leon Romanovsky June 6, 2024, 11:38 a.m. UTC | #3 
On Wed, 05 Jun 2024 01:16:08 -0700, Konstantin Taranov wrote:
> Ignore optional ib_access_flags when an MR is created.
> 
> 

Applied, thanks!

[1/1] RDMA/mana_ib: ignore optional access flags for MRs
      https://git.kernel.org/rdma/rdma/c/62093519622311

Best regards,
Leon Romanovsky June 6, 2024, 11:39 a.m. UTC | #4 
On Thu, Jun 06, 2024 at 08:30:06AM +0000, Konstantin Taranov wrote:
> > > Ignore optional ib_access_flags when an MR is created.
> > 
> > Can you add details on why this is needed?
> 
> Do you mean to the commit message?
> If we do not ignore these optional flags, the reg user mr fails because the next 2 lines:
> 	if (access_flags & ~VALID_MR_FLAGS)
> 		return ERR_PTR(-EINVAL);

I took this patch as is.

Thanks
Konstantin Taranov June 6, 2024, 11:42 a.m. UTC | #5 
> > > > Ignore optional ib_access_flags when an MR is created.
> > >
> > > Can you add details on why this is needed?
> >
> > Do you mean to the commit message?
> > If we do not ignore these optional flags, the reg user mr fails because the
> next 2 lines:
> > 	if (access_flags & ~VALID_MR_FLAGS)
> > 		return ERR_PTR(-EINVAL);
> 
> I took this patch as is.
> 
> Thanks

thanks. It makes sense.
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
index 4f13423..887b09d 100644
--- a/drivers/infiniband/hw/mana/mr.c
+++ b/drivers/infiniband/hw/mana/mr.c
@@ -112,6 +112,7 @@  struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
 		  "start 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
 		  start, iova, length, access_flags);
 
+	access_flags &= ~IB_ACCESS_OPTIONAL;
 	if (access_flags & ~VALID_MR_FLAGS)
 		return ERR_PTR(-EINVAL);