From patchwork Fri May 27 18:01:23 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: "Hefty, Sean" <sean.hefty@intel.com>
X-Patchwork-Id: 825142
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4RI1RpB025644
	for <patchwork-linux-rdma@patchwork.kernel.org>;
	Fri, 27 May 2011 18:01:27 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756953Ab1E0SB0 (ORCPT
	<rfc822;patchwork-linux-rdma@patchwork.kernel.org>);
	Fri, 27 May 2011 14:01:26 -0400
Received: from mga03.intel.com ([143.182.124.21]:45059 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755533Ab1E0SB0 convert rfc822-to-8bit (ORCPT
	<rfc822; linux-rdma@vger.kernel.org>); Fri, 27 May 2011 14:01:26 -0400
Received: from azsmga001.ch.intel.com ([10.2.17.19])
	by azsmga101.ch.intel.com with ESMTP; 27 May 2011 11:01:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.65,281,1304319600"; d="scan'208";a="3064769"
Received: from orsmsx603.amr.corp.intel.com ([10.22.226.49])
	by azsmga001.ch.intel.com with ESMTP; 27 May 2011 11:01:25 -0700
Received: from orsmsx103.amr.corp.intel.com (10.22.225.130) by
	orsmsx603.amr.corp.intel.com (10.22.226.49) with Microsoft SMTP
	Server (TLS) id 8.2.255.0; Fri, 27 May 2011 11:01:24 -0700
Received: from orsmsx101.amr.corp.intel.com ([169.254.8.114]) by
	ORSMSX103.amr.corp.intel.com ([169.254.2.66]) with mapi id
	14.01.0289.001; Fri, 27 May 2011 11:01:24 -0700
From: "Hefty, Sean" <sean.hefty@intel.com>
To: Yann Droneaud <ydroneaud@opteya.com>
CC: Roland Dreier <roland@kernel.org>,
	Animesh K Trivedi1 <ATR@zurich.ibm.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Bernard Metzler <BMT@zurich.ibm.com>
Subject: RE: [PATCH:rdmacm] ucma_init: fail if ibv_get_device_list() returns
	empty list
Thread-Topic: [PATCH:rdmacm] ucma_init: fail if ibv_get_device_list()
	returns empty list
Thread-Index: AQHMHJWa/5l46dWvL0euwMIcJz89h5Sg9RQQ
Date: Fri, 27 May 2011 18:01:23 +0000
Message-ID: 
 <1828884A29C6694DAF28B7E6B8A823730119BA@ORSMSX101.amr.corp.intel.com>
References: 
 <OFC348E58C.B4C03447-ONC125789D.0035F094-C125789D.0036C4F7@ch.ibm.com>
	<1306493434.1835.4.camel@deela.quest-ce.net>
	<BANLkTik4e-kygpRTnxfpTdRMSTbyYNO1_Q@mail.gmail.com>
	<1306515973.1835.11.camel@deela.quest-ce.net>
	<1306517515.1835.15.camel@deela.quest-ce.net>
	<1306518158-7770-1-git-send-email-ydroneaud@opteya.com>
In-Reply-To: <1306518158-7770-1-git-send-email-ydroneaud@opteya.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.9.131.214]
MIME-Version: 1.0
Sender: linux-rdma-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-rdma.vger.kernel.org>
X-Mailing-List: linux-rdma@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]);
	Fri, 27 May 2011 18:01:27 +0000 (UTC)

>   ibv_get_device_list() returns the array of available RDMA devices, or
>   sets errno and returns NULL if the request fails. If no devices are
>   found then num_devices is set to 0, and non-NULL is returned.

Thanks.  I think the following fixes the same issue.  If this looks okay to you, I'll will commit.

Signed-off-by: Sean Hefty <sean.hefty@intel.com
---

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/src/cma.c b/src/cma.c
index 846b5ce..86cb455 100755
--- a/src/cma.c
+++ b/src/cma.c
@@ -247,7 +247,7 @@ int ucma_init(void)
                goto err1;

        dev_list = ibv_get_device_list(&dev_cnt);
-       if (!dev_list) {
+       if (!dev_cnt) {
                printf("CMA: unable to get RDMA device list\n");
                ret = ERR(ENODEV);
                goto err1;