From patchwork Fri Sep 28 22:53:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hefty, Sean" X-Patchwork-Id: 1527421 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6000EDF283 for ; Fri, 28 Sep 2012 22:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758588Ab2I1WyR (ORCPT ); Fri, 28 Sep 2012 18:54:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:11010 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758684Ab2I1WyO convert rfc822-to-8bit (ORCPT ); Fri, 28 Sep 2012 18:54:14 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 28 Sep 2012 15:53:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,504,1344236400"; d="scan'208";a="199544922" Received: from fmsmsx106.amr.corp.intel.com ([10.19.9.37]) by orsmga001.jf.intel.com with ESMTP; 28 Sep 2012 15:53:51 -0700 Received: from fmsmsx151.amr.corp.intel.com ([169.254.6.213]) by FMSMSX106.amr.corp.intel.com ([169.254.6.8]) with mapi id 14.01.0355.002; Fri, 28 Sep 2012 15:53:51 -0700 From: "Hefty, Sean" To: "linux-rdma (linux-rdma@vger.kernel.org)" , "miked@mellanox.com" , "Tzahi Oved (tzahio@mellanox.com)" , Roland Dreier , Jason Gunthorpe , "yishaih@mellanox.com" Subject: [PATCH v3 4/7] libibverbs: Add support for XRC QPs Thread-Topic: [PATCH v3 4/7] libibverbs: Add support for XRC QPs Thread-Index: Ac2dyw5SII/QkeW4SNuz/iJWtjKotQ== Date: Fri, 28 Sep 2012 22:53:51 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A8237346A981B5@FMSMSX151.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org XRC queue pairs: xrc defines two new types of QPs. The initiator, or send-side, xrc qp behaves similar to a send- only RC qp. xrc send qp's are managed through the existing QP functions. The send_wr structure is extended in a back- wards compatible way to support posting sends on a send xrc qp, which require specifying the remote xrc srq. The target, or receive-side, xrc qp behaves differently than other implemented qp's. A recv xrc qp can be created, modified, and destroyed like other qp's through the existing calls. The qp_init_attr structure is extended for xrc qp's. Because xrc recv qp's are bound to an xrcd, rather than a pd, it is intended to be used among multiple processes. Any process with access to an xrcd may allocate and connect an xrc recv qp. The actual xrc recv qp is allocated and managed by the kernel. If the owning process explicit destroys the xrc recv qp, it is destroyed. However, if the xrc recv qp is left open when the user process exits or closes its device, then the lifetime of the xrc recv qp is bound with the lifetime of the xrcd. Signed-off-by: Sean Hefty --- change from v2: Use normal ibv_create_qp call if possible include/infiniband/driver.h | 14 ++++++ include/infiniband/kern-abi.h | 5 ++ include/infiniband/verbs.h | 54 ++++++++++++++++++++++-- src/cmd.c | 94 +++++++++++++++++++++++++++++++++++++++++ src/libibverbs.map | 1 5 files changed, 164 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/infiniband/driver.h b/include/infiniband/driver.h index 05ff730..d43ae07 100644 --- a/include/infiniband/driver.h +++ b/include/infiniband/driver.h @@ -81,6 +81,16 @@ struct verbs_srq { uint32_t srq_num; }; +enum verbs_qp_mask { + VERBS_QP_XRCD = 1 << 0, + VERBS_QP_RESERVED = 1 << 1 +}; + +struct verbs_qp { + struct ibv_qp qp; + uint32_t comp_mask; + struct verbs_xrcd *xrcd; +}; typedef struct ibv_device *(*ibv_driver_init_func)(const char *uverbs_sys_path, int abi_version); typedef struct verbs_device *(*verbs_driver_init_func)(const char *uverbs_sys_path, @@ -152,6 +162,10 @@ int ibv_cmd_create_qp(struct ibv_pd *pd, struct ibv_qp *qp, struct ibv_qp_init_attr *attr, struct ibv_create_qp *cmd, size_t cmd_size, struct ibv_create_qp_resp *resp, size_t resp_size); +int ibv_cmd_create_qp_ex(struct ibv_context *context, + struct verbs_qp *qp, struct ibv_qp_init_attr_ex *attr_ex, + struct ibv_create_qp *cmd, size_t cmd_size, + struct ibv_create_qp_resp *resp, size_t resp_size); int ibv_cmd_query_qp(struct ibv_qp *qp, struct ibv_qp_attr *qp_attr, int attr_mask, struct ibv_qp_init_attr *qp_init_attr, diff --git a/include/infiniband/kern-abi.h b/include/infiniband/kern-abi.h index 3d72fa7..b6d5ce9 100644 --- a/include/infiniband/kern-abi.h +++ b/include/infiniband/kern-abi.h @@ -617,6 +617,11 @@ struct ibv_kern_send_wr { __u32 remote_qkey; __u32 reserved; } ud; + struct { + __u64 reserved[3]; + __u32 reserved2; + __u32 remote_srqn; + } xrc; } wr; }; diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index d7dfcd3..f321866 100644 --- a/include/infiniband/verbs.h +++ b/include/infiniband/verbs.h @@ -107,7 +107,8 @@ enum ibv_device_cap_flags { IBV_DEVICE_SYS_IMAGE_GUID = 1 << 11, IBV_DEVICE_RC_RNR_NAK_GEN = 1 << 12, IBV_DEVICE_SRQ_RESIZE = 1 << 13, - IBV_DEVICE_N_NOTIFY_CQ = 1 << 14 + IBV_DEVICE_N_NOTIFY_CQ = 1 << 14, + IBV_DEVICE_XRC = 1 << 20 }; enum ibv_atomic_cap { @@ -454,7 +455,9 @@ struct ibv_srq_init_attr_ex { enum ibv_qp_type { IBV_QPT_RC = 2, IBV_QPT_UC, - IBV_QPT_UD + IBV_QPT_UD, + IBV_QPT_XRC_SEND = 9, + IBV_QPT_XRC_RECV }; struct ibv_qp_cap { @@ -475,6 +478,26 @@ struct ibv_qp_init_attr { int sq_sig_all; }; +enum ibv_qp_init_attr_mask { + IBV_QP_INIT_ATTR_PD = 1 << 0, + IBV_QP_INIT_ATTR_XRCD = 1 << 1, + IBV_QP_INIT_ATTR_RESERVED = 1 << 2 +}; + +struct ibv_qp_init_attr_ex { + void *qp_context; + struct ibv_cq *send_cq; + struct ibv_cq *recv_cq; + struct ibv_srq *srq; + struct ibv_qp_cap cap; + enum ibv_qp_type qp_type; + int sq_sig_all; + + uint32_t comp_mask; + struct ibv_pd *pd; + struct ibv_xrcd *xrcd; +}; + enum ibv_qp_attr_mask { IBV_QP_STATE = 1 << 0, IBV_QP_CUR_STATE = 1 << 1, @@ -590,6 +613,11 @@ struct ibv_send_wr { uint32_t remote_qpn; uint32_t remote_qkey; } ud; + struct { + uint64_t reserved[3]; + uint32_t reserved2; + uint32_t remote_srqn; + } xrc; } wr; }; @@ -771,11 +799,14 @@ struct ibv_context { enum verbs_context_mask { VERBS_CONTEXT_XRCD = 1 << 0, VERBS_CONTEXT_SRQ = 1 << 1, - VERBS_CONTEXT_RESERVED = 1 << 2 + VERBS_CONTEXT_QP = 1 << 2, + VERBS_CONTEXT_RESERVED = 1 << 3 }; struct verbs_context { /* "grows up" - new fields go here */ + struct ibv_qp * (*create_qp_ex)(struct ibv_context *context, + struct ibv_qp_init_attr_ex *qp_init_attr_ex); uint32_t (*get_srq_num)(struct ibv_srq *srq); struct ibv_srq * (*create_srq_ex)(struct ibv_context *context, struct ibv_srq_init_attr_ex *srq_init_attr_ex); @@ -1143,6 +1174,23 @@ static inline int ibv_post_srq_recv(struct ibv_srq *srq, struct ibv_qp *ibv_create_qp(struct ibv_pd *pd, struct ibv_qp_init_attr *qp_init_attr); +static inline struct ibv_qp * +ibv_create_qp_ex(struct ibv_context *context, struct ibv_qp_init_attr_ex *qp_init_attr_ex) +{ + struct verbs_context *vctx; + uint32_t mask = qp_init_attr_ex->comp_mask; + + if (mask == IBV_QP_INIT_ATTR_PD) + return ibv_create_qp(qp_init_attr_ex->pd, + (struct ibv_qp_init_attr *) qp_init_attr_ex); + + if (!(vctx = verbs_get_ctx_op(context, create_qp_ex))) { + errno = ENOSYS; + return NULL; + } + return vctx->create_qp_ex(context, qp_init_attr_ex); +} + /** * ibv_modify_qp - Modify a queue pair. */ diff --git a/src/cmd.c b/src/cmd.c index 641ab28..87ac062 100644 --- a/src/cmd.c +++ b/src/cmd.c @@ -666,6 +666,98 @@ int ibv_cmd_destroy_srq(struct ibv_srq *srq) return 0; } +int ibv_cmd_create_qp_ex(struct ibv_context *context, + struct verbs_qp *qp, struct ibv_qp_init_attr_ex *attr_ex, + struct ibv_create_qp *cmd, size_t cmd_size, + struct ibv_create_qp_resp *resp, size_t resp_size) +{ + struct verbs_xrcd *vxrcd = NULL; + + IBV_INIT_CMD_RESP(cmd, cmd_size, CREATE_QP, resp, resp_size); + + if (attr_ex->comp_mask >= IBV_QP_INIT_ATTR_RESERVED) + return ENOSYS; + + cmd->user_handle = (uintptr_t) qp; + + if (attr_ex->comp_mask & IBV_QP_INIT_ATTR_XRCD) { + vxrcd = container_of(attr_ex->xrcd, struct verbs_xrcd, xrcd); + cmd->pd_handle = vxrcd->handle; + } else { + if (!(attr_ex->comp_mask & IBV_QP_INIT_ATTR_PD)) + return EINVAL; + + cmd->pd_handle = attr_ex->pd->handle; + cmd->send_cq_handle = attr_ex->send_cq->handle; + + if (attr_ex->qp_type != IBV_QPT_XRC_SEND) { + cmd->recv_cq_handle = attr_ex->recv_cq->handle; + cmd->srq_handle = attr_ex->srq ? attr_ex->srq->handle : 0; + } + } + + cmd->max_send_wr = attr_ex->cap.max_send_wr; + cmd->max_recv_wr = attr_ex->cap.max_recv_wr; + cmd->max_send_sge = attr_ex->cap.max_send_sge; + cmd->max_recv_sge = attr_ex->cap.max_recv_sge; + cmd->max_inline_data = attr_ex->cap.max_inline_data; + cmd->sq_sig_all = attr_ex->sq_sig_all; + cmd->qp_type = attr_ex->qp_type; + cmd->is_srq = !!attr_ex->srq; + cmd->reserved = 0; + + if (write(context->cmd_fd, cmd, cmd_size) != cmd_size) + return errno; + + (void) VALGRIND_MAKE_MEM_DEFINED(resp, resp_size); + + if (abi_ver > 3) { + attr_ex->cap.max_recv_sge = resp->max_recv_sge; + attr_ex->cap.max_send_sge = resp->max_send_sge; + attr_ex->cap.max_recv_wr = resp->max_recv_wr; + attr_ex->cap.max_send_wr = resp->max_send_wr; + attr_ex->cap.max_inline_data = resp->max_inline_data; + } + + if (abi_ver == 4) { + struct ibv_create_qp_resp_v4 *resp_v4 = + (struct ibv_create_qp_resp_v4 *) resp; + + memmove((void *) resp + sizeof *resp, + (void *) resp_v4 + sizeof *resp_v4, + resp_size - sizeof *resp); + } else if (abi_ver <= 3) { + struct ibv_create_qp_resp_v3 *resp_v3 = + (struct ibv_create_qp_resp_v3 *) resp; + + memmove((void *) resp + sizeof *resp, + (void *) resp_v3 + sizeof *resp_v3, + resp_size - sizeof *resp); + } + + qp->qp.handle = resp->qp_handle; + qp->qp.qp_num = resp->qpn; + qp->qp.context = context; + qp->qp.qp_context = attr_ex->qp_context; + qp->qp.pd = attr_ex->pd; + qp->qp.send_cq = attr_ex->send_cq; + qp->qp.recv_cq = attr_ex->recv_cq; + qp->qp.srq = attr_ex->srq; + qp->qp.qp_type = attr_ex->qp_type; + qp->qp.state = IBV_QPS_RESET; + qp->qp.events_completed = 0; + pthread_mutex_init(&qp->qp.mutex, NULL); + pthread_cond_init(&qp->qp.cond, NULL); + + qp->comp_mask = 0; + if (attr_ex->comp_mask & IBV_QP_INIT_ATTR_XRCD) { + qp->comp_mask |= VERBS_QP_XRCD; + qp->xrcd = vxrcd; + } + + return 0; +} + int ibv_cmd_create_qp(struct ibv_pd *pd, struct ibv_qp *qp, struct ibv_qp_init_attr *attr, struct ibv_create_qp *cmd, size_t cmd_size, @@ -674,7 +766,7 @@ int ibv_cmd_create_qp(struct ibv_pd *pd, IBV_INIT_CMD_RESP(cmd, cmd_size, CREATE_QP, resp, resp_size); cmd->user_handle = (uintptr_t) qp; - cmd->pd_handle = pd->handle; + cmd->pd_handle = pd->handle; cmd->send_cq_handle = attr->send_cq->handle; cmd->recv_cq_handle = attr->recv_cq->handle; cmd->srq_handle = attr->srq ? attr->srq->handle : 0; diff --git a/src/libibverbs.map b/src/libibverbs.map index c8ec645..4249793 100644 --- a/src/libibverbs.map +++ b/src/libibverbs.map @@ -101,5 +101,6 @@ IBVERBS_1.1 { ibv_cmd_open_xrcd; ibv_cmd_close_xrcd; ibv_cmd_create_srq_ex; + ibv_cmd_create_qp_ex; } IBVERBS_1.0;