From patchwork Tue Dec 1 16:15:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Rosenstock X-Patchwork-Id: 63995 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nB1GI31K031525 for ; Tue, 1 Dec 2009 16:18:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016AbZLAQRz (ORCPT ); Tue, 1 Dec 2009 11:17:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754020AbZLAQRz (ORCPT ); Tue, 1 Dec 2009 11:17:55 -0500 Received: from qmta03.westchester.pa.mail.comcast.net ([76.96.62.32]:52049 "EHLO QMTA03.westchester.pa.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbZLAQRz (ORCPT ); Tue, 1 Dec 2009 11:17:55 -0500 Received: from OMTA23.westchester.pa.mail.comcast.net ([76.96.62.74]) by QMTA03.westchester.pa.mail.comcast.net with comcast id Bogu1d0061c6gX853sJ2Pn; Tue, 01 Dec 2009 16:18:02 +0000 Received: from hal.comcast.net ([75.69.247.31]) by OMTA23.westchester.pa.mail.comcast.net with comcast id BsSU1d00Q0hNrtn3jsSUEQ; Tue, 01 Dec 2009 16:26:29 +0000 Received: from hal.comcast.net (localhost.localdomain [127.0.0.1]) by hal.comcast.net (8.14.3/8.14.3) with ESMTP id nB1GG2Ki014863; Tue, 1 Dec 2009 11:16:07 -0500 Received: (from hnrose@localhost) by hal.comcast.net (8.14.3/8.14.3/Submit) id nB1GFnCm014832; Tue, 1 Dec 2009 11:15:49 -0500 Date: Tue, 1 Dec 2009 11:15:48 -0500 From: Hal Rosenstock To: sashak@voltaire.com Cc: linux-rdma@vger.kernel.org Subject: [PATCH] opensm/osm_sm_mad_ctrl.c: Make some minor simplifications Message-ID: <20091201161548.GA14828@comcast.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org diff --git a/opensm/opensm/osm_sm_mad_ctrl.c b/opensm/opensm/osm_sm_mad_ctrl.c index 74beb1c..0ccc327 100644 --- a/opensm/opensm/osm_sm_mad_ctrl.c +++ b/opensm/opensm/osm_sm_mad_ctrl.c @@ -260,9 +260,6 @@ static void sm_mad_ctrl_process_get_resp(IN osm_sm_mad_ctrl_t * p_ctrl, goto Exit; } - if (msg_id == CL_DISP_MSGID_NONE) - goto Exit; - /* Post this MAD to the dispatcher for asynchronous processing by the appropriate controller. @@ -319,14 +316,6 @@ static void sm_mad_ctrl_process_get(IN osm_sm_mad_ctrl_t * p_ctrl, OSM_LOG(p_ctrl->p_log, OSM_LOG_VERBOSE, "Ignoring SubnGet MAD - unsupported attribute 0x%X\n", cl_ntoh16(p_smp->attr_id)); - break; - } - - if (msg_id == CL_DISP_MSGID_NONE) { - /* - There is an unknown MAD attribute type for which there is - no recipient. Simply retire the MAD here. - */ osm_mad_pool_put(p_ctrl->p_mad_pool, p_madw); goto Exit; } @@ -397,14 +386,6 @@ static void sm_mad_ctrl_process_set(IN osm_sm_mad_ctrl_t * p_ctrl, "Unsupported attribute 0x%X\n", cl_ntoh16(p_smp->attr_id)); osm_dump_dr_smp(p_ctrl->p_log, p_smp, OSM_LOG_ERROR); - break; - } - - if (msg_id == CL_DISP_MSGID_NONE) { - /* - There is an unknown MAD attribute type for which there is - no recipient. Simply retire the MAD here. - */ osm_mad_pool_put(p_ctrl->p_mad_pool, p_madw); goto Exit; } @@ -484,14 +465,6 @@ static void sm_mad_ctrl_process_trap(IN osm_sm_mad_ctrl_t * p_ctrl, "Unsupported attribute 0x%X\n", cl_ntoh16(p_smp->attr_id)); osm_dump_dr_smp(p_ctrl->p_log, p_smp, OSM_LOG_ERROR); - break; - } - - if (msg_id == CL_DISP_MSGID_NONE) { - /* - There is an unknown MAD attribute type for which there is - no recipient. Simply retire the MAD here. - */ osm_mad_pool_put(p_ctrl->p_mad_pool, p_madw); goto Exit; }