From patchwork Fri Mar 25 01:20:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 660891 X-Patchwork-Delegate: alexne@voltaire.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p2P1FmtH026213 for ; Fri, 25 Mar 2011 01:15:59 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933828Ab1CYBP7 (ORCPT ); Thu, 24 Mar 2011 21:15:59 -0400 Received: from nspiron-2.llnl.gov ([128.115.41.82]:52766 "EHLO nspiron-2.llnl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932165Ab1CYBP6 (ORCPT ); Thu, 24 Mar 2011 21:15:58 -0400 X-Attachments: None Received: from eris.llnl.gov (HELO trebuchet.chaos) ([134.9.2.84]) by nspiron-2.llnl.gov with SMTP; 24 Mar 2011 18:15:58 -0700 Date: Thu, 24 Mar 2011 18:20:56 -0700 From: Ira Weiny To: Alex Netes Cc: "linux-rdma@vger.kernel.org" Subject: [PATCH 4/4] opensm/console: add "print all" to print_counters console command Message-Id: <20110324182056.b47260e5.weiny2@llnl.gov> X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.4; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 25 Mar 2011 01:15:59 +0000 (UTC) diff --git a/include/opensm/osm_perfmgr_db.h b/include/opensm/osm_perfmgr_db.h index 8f4706d..57e0fb3 100644 --- a/include/opensm/osm_perfmgr_db.h +++ b/include/opensm/osm_perfmgr_db.h @@ -183,6 +183,7 @@ perfmgr_db_err_t perfmgr_db_clear_prev_dc(perfmgr_db_t * db, uint64_t guid, void perfmgr_db_clear_counters(perfmgr_db_t * db); perfmgr_db_err_t perfmgr_db_dump(perfmgr_db_t * db, char *file, perfmgr_db_dump_t dump_type); +void perfmgr_db_print_all(perfmgr_db_t * db, FILE *fp); void perfmgr_db_print_by_name(perfmgr_db_t * db, char *nodename, FILE *fp); void perfmgr_db_print_by_guid(perfmgr_db_t * db, uint64_t guid, FILE *fp); diff --git a/opensm/osm_console.c b/opensm/osm_console.c index 0ee528e..114c569 100644 --- a/opensm/osm_console.c +++ b/opensm/osm_console.c @@ -244,7 +244,8 @@ static void help_perfmgr(FILE * out, int detail) fprintf(out, " [dump_counters [mach]] -- dump the counters (optionally in [mach]ine readable format)\n"); fprintf(out, - " [print_counters ] -- print the counters for the specified node\n"); + " [print_counters []] -- print the internal counters\n" + " Optionaly limit output by name or guid\n"); fprintf(out, " [dump_redir []] -- dump the redirection table\n"); fprintf(out, @@ -1358,13 +1359,8 @@ static void perfmgr_parse(char **p_last, osm_opensm_t * p_osm, FILE * out) } } else if (strcmp(p_cmd, "print_counters") == 0) { p_cmd = name_token(p_last); - if (p_cmd) { - osm_perfmgr_print_counters(&p_osm->perfmgr, - p_cmd, out); - } else { - fprintf(out, - "print_counters requires a node name or node GUID to be specified\n"); - } + osm_perfmgr_print_counters(&p_osm->perfmgr, p_cmd, + out); } else if (strcmp(p_cmd, "dump_redir") == 0) { p_cmd = name_token(p_last); dump_redir(p_osm, p_cmd, out); diff --git a/opensm/osm_perfmgr.c b/opensm/osm_perfmgr.c index 6952d72..e6070c3 100644 --- a/opensm/osm_perfmgr.c +++ b/opensm/osm_perfmgr.c @@ -1740,10 +1740,13 @@ void osm_perfmgr_dump_counters(osm_perfmgr_t * pm, perfmgr_db_dump_t dump_type) *******************************************************************/ void osm_perfmgr_print_counters(osm_perfmgr_t * pm, char *nodename, FILE * fp) { - uint64_t guid = strtoull(nodename, NULL, 0); - if (guid == 0 && errno) - perfmgr_db_print_by_name(pm->db, nodename, fp); - else - perfmgr_db_print_by_guid(pm->db, guid, fp); + if (nodename) { + uint64_t guid = strtoull(nodename, NULL, 0); + if (guid == 0 && errno) + perfmgr_db_print_by_name(pm->db, nodename, fp); + else + perfmgr_db_print_by_guid(pm->db, guid, fp); + } else + perfmgr_db_print_all(pm->db, fp); } #endif /* ENABLE_OSM_PERF_MGR */ diff --git a/opensm/osm_perfmgr_db.c b/opensm/osm_perfmgr_db.c index 7a96d41..10bd41e 100644 --- a/opensm/osm_perfmgr_db.c +++ b/opensm/osm_perfmgr_db.c @@ -694,6 +694,25 @@ static void db_dump(cl_map_item_t * const p_map_item, void *context) } /********************************************************************** + * print all node data to fp + **********************************************************************/ +void +perfmgr_db_print_all(perfmgr_db_t * db, FILE *fp) +{ + cl_map_item_t *item; + db_node_t *node; + + cl_plock_acquire(&db->lock); + item = cl_qmap_head(&db->pc_data); + while (item != cl_qmap_end(&db->pc_data)) { + node = (db_node_t *)item; + dump_node_hr(node, fp); + item = cl_qmap_next(item); + } + cl_plock_release(&db->lock); +} + +/********************************************************************** * print node data to fp **********************************************************************/ void